Skip to content

handle existing duplicate packages in get_or_create #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
furlongm merged 1 commit into from
Apr 20, 2025
Merged

handle existing duplicate packages in get_or_create #677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 24 additions & 9 deletions packages/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

from arch.models import PackageArchitecture
from packages.models import PackageName, Package, PackageUpdate, PackageCategory, PackageString
from patchman.signals import error_message, info_message
from patchman.signals import error_message, info_message, warning_message


def convert_package_to_packagestring(package):
Expand Down Expand Up @@ -174,14 +174,29 @@ def get_or_create_package(name, epoch, version, release, arch, p_type):
package_name, c = PackageName.objects.get_or_create(name=name)
package_arch, c = PackageArchitecture.objects.get_or_create(name=arch)
with transaction.atomic():
package, c = Package.objects.get_or_create(
name=package_name,
arch=package_arch,
epoch=epoch,
version=version,
release=release,
packagetype=p_type,
)
try:
package, c = Package.objects.get_or_create(
name=package_name,
arch=package_arch,
epoch=epoch,
version=version,
release=release,
packagetype=p_type,
)
except MultipleObjectsReturned:
packages = Package.objects.filter(
name=package_name,
arch=package_arch,
epoch=epoch,
version=version,
release=release,
packagetype=p_type,
)
package = packages.first()
# TODO this should handle gentoo package categories too, otherwise we may be deleting packages
# that should be kept
warning_message.send(sender=None, text=f'Deleting duplicate packages: {packages.exclude(id=package.id)}')
packages.exclude(id=package.id).delete()
return package


Expand Down