Fix tether and dropdown-direction compatibility with bootstrap#143
Closed
howardjing wants to merge 2 commits intofurqanZafar:masterfrom
Closed
Fix tether and dropdown-direction compatibility with bootstrap#143howardjing wants to merge 2 commits intofurqanZafar:masterfrom
howardjing wants to merge 2 commits intofurqanZafar:masterfrom
Conversation
|
I've put this PR up on npm under 'react-selectize-bs' |
|
react-selectize-bs fixed the issue for me! Thanks |
|
|
ghost
approved these changes
Nov 22, 2017
|
I see the changes were approved, great :-). @bruno-sartori @howardjing is this a matter now of rebasing the branch? |
Author
|
Ah, thanks for the heads up. I'll update the PR later today. |
Author
|
#187 has the rebased code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into some issues with using the following properties:
when using react-selectize within an application with bootstrap3 css included.
The issue seems to be a clash between bootstrap and react-selectize over the
.dropdown-menuclass name. I renameddropdown-menutors-dropdown-menuas a sanity check, and it fixed the issues I was having.I don't think this current PR is a great solution as it would break any existing customized css people have made for the dropdown menu, but this was the quickest fix for my purposes.
@furqanZafar I'd appreciate your input as to what you think is the best way to solve this.
See #137 for more details.