Skip to content

Fix tether and dropdown-direction compatibility with bootstrap#143

Closed
howardjing wants to merge 2 commits intofurqanZafar:masterfrom
howardjing:dropdown-css
Closed

Fix tether and dropdown-direction compatibility with bootstrap#143
howardjing wants to merge 2 commits intofurqanZafar:masterfrom
howardjing:dropdown-css

Conversation

@howardjing
Copy link
Copy Markdown

I ran into some issues with using the following properties:

  • tether
  • dropdown-direction

when using react-selectize within an application with bootstrap3 css included.

The issue seems to be a clash between bootstrap and react-selectize over the .dropdown-menu class name. I renamed dropdown-menu to rs-dropdown-menu as a sanity check, and it fixed the issues I was having.

I don't think this current PR is a great solution as it would break any existing customized css people have made for the dropdown menu, but this was the quickest fix for my purposes.

@furqanZafar I'd appreciate your input as to what you think is the best way to solve this.

See #137 for more details.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-4.6%) to 86.012% when pulling ffe679b on howardjing:dropdown-css into 9e936fa on furqanZafar:master.

@htsui
Copy link
Copy Markdown

htsui commented Mar 24, 2017

I've put this PR up on npm under 'react-selectize-bs'

@Gribbs
Copy link
Copy Markdown

Gribbs commented May 19, 2017

react-selectize-bs fixed the issue for me! Thanks

@hwaterke
Copy link
Copy Markdown

react-selectize-bs doesn't solve the problem and is already several versions behind.
I think this needs to be merged. It is anyway not a good idea to use very generic css classnames in such a component.

@mnieber
Copy link
Copy Markdown

mnieber commented Dec 2, 2017

I see the changes were approved, great :-). @bruno-sartori @howardjing is this a matter now of rebasing the branch?

@howardjing
Copy link
Copy Markdown
Author

Ah, thanks for the heads up. I'll update the PR later today.

@howardjing
Copy link
Copy Markdown
Author

#187 has the rebased code

@howardjing howardjing closed this Dec 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants