Solid expect clauses#248
Conversation
j-i-l
left a comment
There was a problem hiding this comment.
@matteodelucchi this fixes the windows install issues and some flaky test logic we had for the build-score cache, as well as, an upcoming error in the newer version of testthat in tographvis (will fail since existing files are overwritten).
Is ready to be merged.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
==========================================
+ Coverage 66.30% 67.51% +1.21%
==========================================
Files 53 50 -3
Lines 10399 10796 +397
==========================================
+ Hits 6895 7289 +394
- Misses 3504 3507 +3 🚀 New features to boost your workflow:
|
@matteodelucchi this looks odd with the '58 commits behind head of main', which is not at all accurate. Any idea what is going on? |
That's weird... It's also weird, that the check-CRAN action is not listed in the "Checks" Tab of this PR... I'm rerunning them to inspect it in more detail. |
Closes #190
This originated from the failing deployment test for Windows which uses the newer version of testthat.
https://github.com/furrer-lab/abn/actions/runs/24714014543/job/72285619505
We are relying on catching some exception based on content from the explanatory message which fails in a newer version (and is also bad practice).