Skip to content

Solid expect clauses#248

Open
j-i-l wants to merge 6 commits into
mainfrom
solid-expect-clauses
Open

Solid expect clauses#248
j-i-l wants to merge 6 commits into
mainfrom
solid-expect-clauses

Conversation

@j-i-l
Copy link
Copy Markdown
Member

@j-i-l j-i-l commented Apr 21, 2026

Closes #190

This originated from the failing deployment test for Windows which uses the newer version of testthat.
https://github.com/furrer-lab/abn/actions/runs/24714014543/job/72285619505

We are relying on catching some exception based on content from the explanatory message which fails in a newer version (and is also bad practice).

@j-i-l j-i-l self-assigned this Apr 21, 2026
Copy link
Copy Markdown
Member Author

@j-i-l j-i-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matteodelucchi this fixes the windows install issues and some flaky test logic we had for the build-score cache, as well as, an upcoming error in the newer version of testthat in tographvis (will fail since existing files are overwritten).

Is ready to be merged.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.51%. Comparing base (d7b018c) to head (fd7d808).
⚠️ Report is 60 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
+ Coverage   66.30%   67.51%   +1.21%     
==========================================
  Files          53       50       -3     
  Lines       10399    10796     +397     
==========================================
+ Hits         6895     7289     +394     
- Misses       3504     3507       +3     

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j-i-l
Copy link
Copy Markdown
Member Author

j-i-l commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests. ✅ Project coverage is 67.51%. Comparing base (d7b018c) to head (e497915). ⚠️ Report is 58 commits behind head on main.
Additional details and impacted files

🚀 New features to boost your workflow:

@matteodelucchi this looks odd with the '58 commits behind head of main', which is not at all accurate. Any idea what is going on?

@matteodelucchi
Copy link
Copy Markdown
Contributor

matteodelucchi commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests. ✅ Project coverage is 67.51%. Comparing base (d7b018c) to head (e497915). ⚠️ Report is 58 commits behind head on main.
Additional details and impacted files
🚀 New features to boost your workflow:

@matteodelucchi this looks odd with the '58 commits behind head of main', which is not at all accurate. Any idea what is going on?

That's weird... It's also weird, that the check-CRAN action is not listed in the "Checks" Tab of this PR... I'm rerunning them to inspect it in more detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gsl not found on Windows build

2 participants