TEST: added visual testing system#1051
Draft
m-agour wants to merge 3 commits into
Draft
Conversation
Contributor
|
Are @maharshi-gor and you working on the same thing without communication ? see #1050 I am lost |
Contributor
Author
|
@skoudoro you are right Serge I didn't see maharshi's PR. they are almost the same. but here I try to use it to detect the errors we already have in fury and we test shading here which is crucial for testing the shaders parts. @maharshi-gor lets talk about this tomorrow. |
- Replaced LooseVersion from distutils.version with Version from packaging.version - Fixes Python 3.12 compatibility where distutils was removed - This was causing CI failures across all build matrix combinations
- Fixed import in fury.testing doctest: use 'from fury.testing import' instead of 'from fury.testing.snapshot import' - Fixed test_text_actor_translation_bug: changed 'color' parameter to 'colors' for fury_actor.text() - Fixed fury.window.analyze_snapshot: changed 'background_threshold' parameter to 'bg_color' to match fury.testing.analyze_snapshot signature - Fixed fury.window.snapshot doctest: added sphere actor to avoid 'no bounding sphere' error
Contributor
|
Did you and @maharshi-gor talked ? What is the final conclusion ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Snapshots analysis system.
Does this mean everything tested is working correctly? No, tests does not cover everything yet, this is just a starting point.
How to proceed from here? whenever we see a bug we apply the visual test and see if the test can't detect the bug we can change the functionality of the snapshot tester and/or add more methods for visual analysis. So, we need to see if everything is workign as expected and before we fix we make this testing syste able to detect it first to prevent future bugs.