[WIP] Adding Tree2D to the UI sub-module#460
Conversation
|
Hello @antrikshmisri! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-08-24 18:39:08 UTC |
Codecov Report
@@ Coverage Diff @@
## master #460 +/- ##
==========================================
+ Coverage 88.53% 88.60% +0.07%
==========================================
Files 31 31
Lines 6575 6968 +393
Branches 787 838 +51
==========================================
+ Hits 5821 6174 +353
- Misses 535 564 +29
- Partials 219 230 +11
|
skoudoro
left a comment
There was a problem hiding this comment.
Hi @antrikshmisri,
I have few questions:
- is it normal to be able to select (highlight) multiple elements. if yes, can we disable it easily?
- When you click on the text, you can not select, can you allow the same behavior as when we click outside the text (same comment for the icon)
- the file
test.pyshould be an additional tutorial so you will need to add an explanation and put it in the right folder
|
Hey @skoudoro ,
I think it totally depends on the use case, some should allow multiselecting and other shouldn't. Nonetheless, I think this feature should be added. All the changes along with this feature will be added with the latest commit. |
|
Hey @skoudoro , all the comments have been addressed as well as the multiselect feature has also been added. |
|
Hey @skoudoro, all the proposed changes have been added. PTAL. |
|
Hi @antrikshmisri, Before starting to review this PR, Can you fix all the conflict, rebase it and address the small pep8 above? Thank you |
|
Hey @antrikshmisri , |
|
Closing this PR here and continuing at #821 as we got no response from author. |
|
Sorry @ganimtron-10 for not being active, I am a bit tied up right now. Let me know if you need any context/help. |
This PR adds
Tree2DUI to the ui sub-module.