Skip to content

fix: truncate download filenames to prevent 'filename too long' on Windows (#875) #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stakeswky wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: truncate download filenames to prevent 'filename too long' on Windows (#875) #877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions Grayjay.ClientServer/Extensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,24 @@ public static string SanitizeFileName(this string fileName)
fileName = fileName.Replace(invalidChar, '_');
return fileName;
}

// Windows MAX_PATH is 260; reserve some room for the directory prefix.
private const int MaxFileNameLength = 200;
/// <summary>
/// Truncates a file name (after sanitization) so that the base name fits within
/// <see cref="MaxFileNameLength"/> characters, preserving the extension.
/// </summary>
public static string TruncateFileName(this string fileName)
{
if (fileName.Length <= MaxFileNameLength)
return fileName;

string ext = Path.GetExtension(fileName); // e.g. ".mp4"
string baseName = Path.GetFileNameWithoutExtension(fileName);
int allowedBase = MaxFileNameLength - ext.Length;
if (allowedBase < 1) allowedBase = 1;
return baseName.Substring(0, Math.Min(baseName.Length, allowedBase)) + ext;
}
public static string SanitizeFileNameWithPath(this string path)
{
string dirName = Path.GetDirectoryName(path);
Expand Down
6 changes: 3 additions & 3 deletions Grayjay.ClientServer/Models/Downloads/VideoDownload.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ public async Task Download(ManagedHttpClient client, Action<double> onProgress,
var representation = videoRepresentations?.FirstOrDefault();
var mimeType = representation?.MimeType ?? VideoSource.Container;

VideoFileName = $"{VideoDetails.ID.Value} [{VideoSource.Width}x{VideoSource.Height}].{VideoHelper.VideoContainerToExtension(mimeType)}".SanitizeFileName();
VideoFileName = $"{VideoDetails.ID.Value} [{VideoSource.Width}x{VideoSource.Height}].{VideoHelper.VideoContainerToExtension(mimeType)}".SanitizeFileName().TruncateFileName();
VideoFilePath = Path.Combine(downloadDir, VideoFileName);
}
string audioDash = (AudioSource is DashManifestRawAudioSource dAudioSource) ? dAudioSource.Generate() : null;
Expand All @@ -331,12 +331,12 @@ public async Task Download(ManagedHttpClient client, Action<double> onProgress,
var representation = audioRepresentations?.FirstOrDefault();
var mimeType = representation?.MimeType ?? AudioSource.Container;

AudioFileName = $"{VideoDetails.ID.Value} [{AudioSource.Language}-{AudioSource.Bitrate}].{VideoHelper.AudioContainerToExtension(mimeType)}".SanitizeFileName();
AudioFileName = $"{VideoDetails.ID.Value} [{AudioSource.Language}-{AudioSource.Bitrate}].{VideoHelper.AudioContainerToExtension(mimeType)}".SanitizeFileName().TruncateFileName();
AudioFilePath = Path.Combine(downloadDir , AudioFileName);
}
if(SubtitleSourcetoUse != null)
{
SubtitleFileName = $"{VideoDetails.ID.Value} [{SubtitleSourcetoUse.Name}].{VideoHelper.SubtitleContainerToExtension(SubtitleSourcetoUse.Format)}".SanitizeFileName();
SubtitleFileName = $"{VideoDetails.ID.Value} [{SubtitleSourcetoUse.Name}].{VideoHelper.SubtitleContainerToExtension(SubtitleSourcetoUse.Format)}".SanitizeFileName().TruncateFileName();
SubtitleFilePath = Path.Combine(downloadDir, SubtitleFileName);
}
var progressLock = new Object();
Expand Down