Skip to content

feat(subscriptions): add subscription to group from channel context menu#929

Open
guthubrx wants to merge 1 commit into
futo-org:masterfrom
guthubrx:feat/channel-add-to-group
Open

feat(subscriptions): add subscription to group from channel context menu#929
guthubrx wants to merge 1 commit into
futo-org:masterfrom
guthubrx:feat/channel-add-to-group

Conversation

@guthubrx
Copy link
Copy Markdown

Summary

  • Adds an "Add to group" sub-menu in the subscription context menu on the channel page
  • Shows all existing subscription groups with a checkmark for groups the channel already belongs to
  • Toggling a group immediately saves the updated membership via subscriptionGroupSave()
  • Groups are fetched in parallel with subscription settings via Promise.all (no latency regression)
  • Graceful fallback: if group fetch fails, the menu still opens without the "Add to group" section

Files changed

  • src/Menus.tsxgetSubscriptionMenu() accepts groups parameter, adds MenuItemGroup sub-menu with toggle behavior
  • src/pages/Channel/index.tsx — parallel fetch with Promise.all + .catch() fallback, passes groups to menu builder

@futo-cla-pr-labler
Copy link
Copy Markdown

Please sign our contributor license agreement at https://cla.futo.org

@futo-cla-pr-labler
Copy link
Copy Markdown

Please sign our contributor license agreement at https://cla.futo.org

@guthubrx
Copy link
Copy Markdown
Author

/recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants