feat(video): open content in new window on Cmd/Ctrl+click#932
Open
guthubrx wants to merge 1 commit into
Open
Conversation
Cmd+click (macOS) or Ctrl+click (Windows/Linux) on a video thumbnail opens the video in a new window instead of navigating in the current one. Intercepts click events globally and monkey-patches history.pushState to catch router navigations. Cross-window navigation intent is bridged via localStorage with a 5-second validity window.
guthubrx
force-pushed
the
pr/cmd-click-new-window
branch
from
51a5d25 to
2542d01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
history.pushStateso router navigations are caught toolocalStoragewith a 5-second validity window to avoid stale entriesChanges
WindowBackend.ts(new): static class exposingmarkCmdClick/consumeCmdClick/openInNewWindow/consumeNavIntentVideoProvider.tsx:openVideoandopenVideoByUrlcheck the Cmd/Ctrl flag and delegate toWindowBackend.openInNewWindowwhen setindex.tsx: global capture-phase click listener,pushStateinterception, and consumption of nav intent on new-window mountFrontend only, no backend change, no new dependency.