feat: support dynamic Peertube source icons via grayjay-plugin-peertube implementation#943
Open
geco wants to merge 1 commit into
Open
feat: support dynamic Peertube source icons via grayjay-plugin-peertube implementation#943geco wants to merge 1 commit into
geco wants to merge 1 commit into
Conversation
…ck to static config
|
Please sign our contributor license agreement at https://cla.futo.org |
|
Please sign our contributor license agreement at https://cla.futo.org |
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: support dynamic Peertube source icons via grayjay-plugin-peertube implementation
Summary
Currently, source icons are static and derived solely from the
iconUrldefined in the plugin's configuration JSON. While this works for general purposes, it doesn't allow plugins to provide dynamic icons based on the specific instance configuration.This PR introduces a mechanism to fetch dynamic icons by calling a
getIcon()method directly from the plugin implementation if available.Changes
/sources/GetDynamicIconinSourcesControllerthat invokes thegetIconmethod of the target plugin.getDynamicIconintoSourcesBackendandStateGlobal.absoluteIconUrl(derived from the JSONiconUrl).Use Case: PeerTube
This is specifically designed to support the PeerTube plugin, allowing it to display the actual icon configured on the peer-to-peer instance.
The plugin-side implementation of this feature can be found in this PR:
👉 futo-org/grayjay-plugin-peertube#3
Testing
getIconmethod now display their dynamic icon.