Fix default selection in more-keys popup#2141
Open
minisiowo wants to merge 1 commit into
Open
Conversation
|
Please sign our contributor license agreement at https://cla.futo.org |
|
Please sign our contributor license agreement at https://cla.futo.org |
Author
|
Hi, the CLA has been signed. Could you please update the PR status? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2140
Problem
The long-press more-keys popup currently initializes its active key using coordinate-based hit testing based on the last touch position. If the translated touch position misses the popup key area due to touch jitter or event timing, the popup may open without an active (default) selection.
As a result, the default more key (for example,
śfor Polishs) may not be selected immediately, and releasing the finger without moving can fail to commit the expected alternative character.Solution
This change preserves the existing coordinate-based selection behavior while adding a fallback mechanism:
onDownEvent(), the panel selects the default key if no key is currently selectedTesting
Manually tested on a physical device:
sśis selected immediately when the popup appearsś