chore: fix lint error

Author: MaineK00n

.golangci.yml

@@ -27,6 +27,7 @@ linters:
         - name: increment-decrement
         - name: indent-error-flow
         - name: package-comments
+          disabled: true
         - name: range
         - name: receiver-naming
         - name: redefines-builtin-id
@@ -38,7 +39,18 @@ linters:
         - name: var-declaration
         - name: var-naming
     staticcheck: # https://golangci-lint.run/usage/linters/#staticcheck
-      checks: ["all", "-SA1019"]
+      checks:
+        - all
+        - -ST1000 # at least one file in a package should have a package comment
+        - -ST1005 # error strings should not be capitalized
+  exclusions:
+    rules:
+      - source: "defer .+\\.Close\\(\\)"
+        linters:
+          - errcheck
+      - source: "defer os.Remove\\(.+\\)"
+        linters:
+          - errcheck
 
 formatters:
   enable:

cache/bolt_test.go

@@ -54,7 +54,6 @@ func TestSetupBolt(t *testing.T) {
 		}
 		return nil
 	})
-
 }
 
 func TestEnsureBuckets(t *testing.T) {

config/config_v1.go

@@ -133,7 +133,7 @@ func convertToLatestConfig(pathToToml string) error {
 	if err := toml.NewEncoder(&buf).Encode(c); err != nil {
 		return xerrors.Errorf("Failed to encode to toml: %w", err)
 	}
-	str := strings.Replace(buf.String(), "\n  [", "\n\n  [", -1)
+	str := strings.ReplaceAll(buf.String(), "\n  [", "\n\n  [")
 	str = fmt.Sprintf("%s\n\n%s",
 		"# See README for details: https://vuls.io/docs/en/config.toml.html",
 		str)

config/scanmodule.go

@@ -56,7 +56,7 @@ func (s ScanModule) IsScanPort() bool {
 
 // IsZero return the struct value are all false
 func (s ScanModule) IsZero() bool {
-	return !(s.IsScanOSPkg() || s.IsScanWordPress() || s.IsScanLockFile() || s.IsScanPort())
+	return !s.IsScanOSPkg() && !s.IsScanWordPress() && !s.IsScanLockFile() && !s.IsScanPort()
 }
 
 func (s *ScanModule) ensure() error {

config/slackconf.go

@@ -32,10 +32,8 @@ func (c *SlackConf) Validate() (errs []error) {
 	if len(c.Channel) == 0 {
 		errs = append(errs, xerrors.New("slack.channel must not be empty"))
 	} else {
-		if !(strings.HasPrefix(c.Channel, "#") ||
-			c.Channel == "${servername}") {
-			errs = append(errs, xerrors.Errorf(
-				"channel's prefix must be '#', channel: %s", c.Channel))
+		if !strings.HasPrefix(c.Channel, "#") && c.Channel != "${servername}" {
+			errs = append(errs, xerrors.Errorf("channel's prefix must be '#', channel: %s", c.Channel))
 		}
 	}
 

contrib/future-vuls/pkg/config/config.go

@@ -2,10 +2,15 @@
 package config
 
 const (
-	DiscoverTomlFileName        = "discover_list.toml"
-	SnmpVersion                 = "v2c"
-	FvulsDomain                 = "vuls.biz"
-	Community                   = "public"
+	// DiscoverTomlFileName ...
+	DiscoverTomlFileName = "discover_list.toml"
+	// SnmpVersion ...
+	SnmpVersion = "v2c"
+	// FvulsDomain ...
+	FvulsDomain = "vuls.biz"
+	// Community ...
+	Community = "public"
+	// DiscoverTomlTimeStampFormat ...
 	DiscoverTomlTimeStampFormat = "20060102150405"
 )
 

contrib/future-vuls/pkg/discover/discover.go

@@ -113,7 +113,9 @@ func executeSnmp2cpe(addr string, snmpVersion string, community string) (cpes ma
 	if _, err := stdin.Write(result); err != nil {
 		return nil, fmt.Errorf("failed to write to stdIn. err: %v", err)
 	}
-	stdin.Close()
+	if err := stdin.Close(); err != nil {
+		return nil, fmt.Errorf("failed to close stdIn. err: %v", err)
+	}
 	output, err := cmd.Output()
 	if err != nil {
 		return nil, fmt.Errorf("failed to convert snmp2cpe result. err: %v", err)

contrib/snmp2cpe/pkg/cmd/version/version.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"os"
 
+	"github.com/pkg/errors"
 	"github.com/spf13/cobra"
 
 	"github.com/future-architect/vuls/config"
@@ -15,8 +16,11 @@ func NewCmdVersion() *cobra.Command {
 		Use:   "version",
 		Short: "Print the version",
 		Args:  cobra.NoArgs,
-		Run: func(_ *cobra.Command, _ []string) {
-			fmt.Fprintf(os.Stdout, "snmp2cpe %s %s\n", config.Version, config.Revision)
+		RunE: func(_ *cobra.Command, _ []string) error {
+			if _, err := fmt.Fprintf(os.Stdout, "snmp2cpe %s %s\n", config.Version, config.Revision); err != nil {
+				return errors.Wrap(err, "failed to print version")
+			}
+			return nil
 		},
 	}
 	return cmd

contrib/trivy/pkg/converter.go

@@ -154,7 +154,8 @@ func Convert(results types.Results) (result *models.ScanResult, err error) {
 		}
 
 		// --list-all-pkgs flg of trivy will output all installed packages, so collect them.
-		if trivyResult.Class == types.ClassOSPkg {
+		switch trivyResult.Class {
+		case types.ClassOSPkg:
 			for _, p := range trivyResult.Packages {
 				pv := p.Version
 				if p.Release != "" {
@@ -186,7 +187,7 @@ func Convert(results types.Results) (result *models.ScanResult, err error) {
 				v.AddBinaryName(p.Name)
 				srcPkgs[p.SrcName] = v
 			}
-		} else if trivyResult.Class == types.ClassLangPkg {
+		case types.ClassLangPkg:
 			libScanner := uniqueLibraryScannerPaths[trivyResult.Target]
 			libScanner.Type = trivyResult.Type
 			for _, p := range trivyResult.Packages {
@@ -198,6 +199,7 @@ func Convert(results types.Results) (result *models.ScanResult, err error) {
 				})
 			}
 			uniqueLibraryScannerPaths[trivyResult.Target] = libScanner
+		default:
 		}
 	}
 

detector/cti.go

@@ -4,6 +4,7 @@ package detector
 
 import (
 	"encoding/json"
+	"errors"
 	"net/http"
 	"time"
 
@@ -212,7 +213,7 @@ func newCTIDB(cnf config.VulnDictInterface) (ctidb.DB, error) {
 	}
 	driver, err := ctidb.NewDB(cnf.GetType(), path, cnf.GetDebugSQL(), ctidb.Option{})
 	if err != nil {
-		if xerrors.Is(err, ctidb.ErrDBLocked) {
+		if errors.Is(err, ctidb.ErrDBLocked) {
 			return nil, xerrors.Errorf("Failed to init cti DB. SQLite3: %s is locked. err: %w", cnf.GetSQLite3Path(), err)
 		}
 		return nil, xerrors.Errorf("Failed to init cti DB. DB Path: %s, err: %w", path, err)