Set minimum TLS version for SMTP email client#2550
Open
rafael81 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This hardens the SMTP email reporter TLS client configuration by setting
MinVersion: tls.VersionTLS12while preserving the existingtlsInsecureSkipVerifyoption added for configurable compatibility.This addresses the remaining TLS configuration concern in #1513: the SMTP reporter had an explicit
tls.Config, but did not set a minimum protocol version.Validation
go test ./reportergit diff --checkTransparency
This PR was prepared with OpenAI/Codex assistance and manually reviewed before submission.
IssueHunt Summary
Referenced issues
This pull request has been submitted to: