Fixed import of createLogger#200
Closed
justinhaaheim wants to merge 1 commit into
Closed
Conversation
Per (https://github.com/evgenyrodionov/redux-logger/blob/master/src/index.js) the way to import createLogger is as a destructured function -- it is not necessarily the default.
FruitieX
approved these changes
Jun 20, 2017
Contributor
There was a problem hiding this comment.
Thank you for the fix. As you say the old code was potentially misleading due to (incorrectly) naming a default import the same as a named export.
Edit: Looks like the module exports in redux-logger have changed, and this patch only worked with more recent versions of redux-logger. Fixed by updating redux-logger.
Contributor
|
Continuing in #208 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per (https://github.com/evgenyrodionov/redux-logger/blob/master/src/index.js) the way to import createLogger is as a destructured function -- it is not necessarily the default.