Skip to content

Could org.itstack:itstack-demo-design:1.0-SNAPSHOT drop off redundant dependencies?#57

Open
Celebrate-future wants to merge 5 commits into
fuzhengwei:masterfrom
Celebrate-future:master
Open

Could org.itstack:itstack-demo-design:1.0-SNAPSHOT drop off redundant dependencies?#57
Celebrate-future wants to merge 5 commits into
fuzhengwei:masterfrom
Celebrate-future:master

Conversation

@Celebrate-future

Copy link
Copy Markdown

image
This figure presents the dependency tree between multiple modules in itstack-demo-design. As shown in this figure, Library

ch.qos.logback:logback-core:jar:1.0.9:compile
org.slf4j:jcl-over-slf4j:jar:1.7.5:compile
ch.qos.logback:logback-classic:jar:1.0.9:compile


in itstack-demo-design-1-01
itstack-demo-design-1-00
itstack-demo-design-1-02
itstack-demo-design-2-00
itstack-demo-design-2-01
itstack-demo-design-2-02
itstack-demo-design-3-00
itstack-demo-design-3-01
itstack-demo-design-3-02
itstack-demo-design-4-00
itstack-demo-design-4-01
itstack-demo-design-4-02
itstack-demo-design-5-00
itstack-demo-design-6-00
itstack-demo-design-6-01
itstack-demo-design-6-02
itstack-demo-design-7-01
itstack-demo-design-7-02
itstack-demo-design-8-01
itstack-demo-design-8-02
itstack-demo-design-9-00
itstack-demo-design-9-01
itstack-demo-design-9-02
itstack-demo-design-10-00
itstack-demo-design-10-01
itstack-demo-design-10-02
itstack-demo-design-11-02
itstack-demo-design-11-01
itstack-demo-design-12-00
itstack-demo-design-13-00
itstack-demo-design-13-01
itstack-demo-design-13-02
itstack-demo-design-14-00
itstack-demo-design-14-01
itstack-demo-design-14-02
itstack-demo-design-15-00
itstack-demo-design-16-01
itstack-demo-design-16-02
itstack-demo-design-17-00
itstack-demo-design-18-00
itstack-demo-design-18-01
itstack-demo-design-18-02
itstack-demo-design-19-00
itstack-demo-design-19-01
itstack-demo-design-19-02
itstack-demo-design-20-01
itstack-demo-design-20-02
itstack-demo-design-21-00
itstack-demo-design-22-00

is inherited from their parent module. However, it is not used by itstack-demo-design-18-00, itstack-demo-design-20-01, itstack-demo-design-3-00, itstack-demo-design-4-00, itstack-demo-design-9-00. We can perform refactoring operations in the pom, by removing such redundant dependencies in itstack-demo-design-18-00, itstack-demo-design-20-01, itstack-demo-design-3-00, itstack-demo-design-4-00, itstack-demo-design-9-00.

Specifically, the scope of org.slf4j:jcl-over-slf4j, ch.qos.logback:logback-classic in itstack-demo-design-18-00, itstack-demo-design-20-01, itstack-demo-design-3-00, itstack-demo-design-4-00, itstack-demo-design-9-00 can be changed from compile to provided. The revisions in the pom are described as follows:
image

Removing the redundant dependencies can reduce the size of project and prevent potential dependency conflict issues (i.e., multiple versions of the same library). More importantly, one of the redundant dependencies ch.qos.logback:logback-core:jar:1.0.9:compile incorporates a medium-level vulnerability SNYK-JAVA-CHQOSLOGBACK-1726923.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant