Commit b61593f
committed
fix(insert-from-url): correct the NoInteract <-> WithDialog inversion
NoInteract state='True' means 'suppress the dialog' = 'With dialog: Off'.
The ToXml and FromXml were mapping 'WithDialog=true' to state='True'
(semantically backwards); round-trips were byte-intact but the display
text said 'With dialog: On' for steps that FM Pro authored with the
dialog suppressed and vice versa.
Also added regression tests that pin both directions of the mapping so
the invariant can't silently invert again.1 parent 69fe485 commit b61593f
2 files changed
Lines changed: 33 additions & 2 deletions
File tree
- src/SharpFM.Model/Scripting/Steps
- tests/SharpFM.Tests/Scripting/Steps
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
48 | 50 | | |
49 | 51 | | |
50 | 52 | | |
| |||
75 | 77 | | |
76 | 78 | | |
77 | 79 | | |
78 | | - | |
| 80 | + | |
| 81 | + | |
79 | 82 | | |
80 | 83 | | |
81 | 84 | | |
| |||
Lines changed: 28 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
66 | 94 | | |
67 | 95 | | |
68 | 96 | | |
| |||
0 commit comments