fix(scripting): normalize NoInteract <-> WithDialog semantics across 15 POCOs

fuzzzerd · fuzzzerd · commit ba54dd1a2b6e · 2026-04-21T12:57:53.000-05:00
Audit of every step that emits &lt;NoInteract&gt; found 11 POCOs where
ToXml/FromXml/ToDisplayLine jointly produced the wrong display text —
round-tripped byte-intact but said 'With dialog: On' for steps FM Pro
authored with state='True' (dialog suppressed) and vice versa:
Change Password, Dial Phone, Execute SQL, Omit Multiple Records,
Open URL, Re-Login, Recover File, Relookup Field Contents, Replace
Field Contents, Trigger Claris Connect Flow, Truncate Table.

Plus 4 POCOs whose 'WithDialog' field was actually storing NoInteract
raw and compensating at render time — the display was correct but the
field semantic was inverted for programmatic use: Delete All Records,
Delete Portal Row, Delete Record/Request, Revert Record/Request.

All 15 now use the same rule: WithDialog=true means 'show the dialog',
ToXml emits state='False' for that case, FromXml reads state!='True',
and the display reads WithDialog directly as On/Off.

Added NoInteractSemanticTests — a [Theory] over every NoInteract-bearing
step plus a discovery test that fails if a new POCO ships with the
child but isn't in the Theory data. Pins the invariant.
diff --git a/src/SharpFM.Model/Scripting/Steps/ChangePasswordStep.cs b/src/SharpFM.Model/Scripting/Steps/ChangePasswordStep.cs
@@ -35,7 +35,7 @@ public override XElement ToXml() =>
             new XAttribute("name", XmlName),
             new XElement("OldPassword", OldPassword.ToXml("Calculation")),
             new XElement("NewPassword", Password.ToXml("Calculation")),
-            new XElement("NoInteract", new XAttribute("state", WithDialog ? "True" : "False")));
+            new XElement("NoInteract", new XAttribute("state", WithDialog ? "False" : "True")));
 
     public override string ToDisplayLine() =>
         "Change Password [ " + "Old Password: " + OldPassword.Text + " ; " + "Password: " + Password.Text + " ; " + "With dialog: " + (WithDialog ? "On" : "Off") + " ]";
@@ -49,7 +49,7 @@ public override string ToDisplayLine() =>
         var password_vWrapEl = step.Element("NewPassword");
         var password_vCalcEl = password_vWrapEl?.Element("Calculation");
         var password_v = password_vCalcEl is not null ? Calculation.FromXml(password_vCalcEl) : new Calculation("");
-        var withDialog_v = step.Element("NoInteract")?.Attribute("state")?.Value == "True";
+        var withDialog_v = step.Element("NoInteract")?.Attribute("state")?.Value != "True";
         return new ChangePasswordStep(oldPassword_v, password_v, withDialog_v, enabled);
     }
 
diff --git a/src/SharpFM.Model/Scripting/Steps/DeleteAllRecordsStep.cs b/src/SharpFM.Model/Scripting/Steps/DeleteAllRecordsStep.cs
@@ -29,15 +29,15 @@ public override XElement ToXml() =>
             new XAttribute("id", XmlId),
             new XAttribute("name", XmlName),
             new XElement("NoInteract",
-                new XAttribute("state", WithDialog ? "True" : "False")));
+                new XAttribute("state", WithDialog ? "False" : "True")));
 
     public override string ToDisplayLine() =>
-        $"Delete All Records [ With dialog: {(WithDialog ? "Off" : "On")} ]";
+        $"Delete All Records [ With dialog: {(WithDialog ? "On" : "Off")} ]";
 
     public static new ScriptStep FromXml(XElement step)
     {
         var enabled = step.Attribute("enable")?.Value != "False";
-        var state = step.Element("NoInteract")?.Attribute("state")?.Value == "True";
+        var state = step.Element("NoInteract")?.Attribute("state")?.Value != "True";
         return new DeleteAllRecordsStep(state, enabled);
     }
 
diff --git a/src/SharpFM.Model/Scripting/Steps/DeletePortalRowStep.cs b/src/SharpFM.Model/Scripting/Steps/DeletePortalRowStep.cs
@@ -29,15 +29,15 @@ public override XElement ToXml() =>
             new XAttribute("id", XmlId),
             new XAttribute("name", XmlName),
             new XElement("NoInteract",
-                new XAttribute("state", WithDialog ? "True" : "False")));
+                new XAttribute("state", WithDialog ? "False" : "True")));
 
     public override string ToDisplayLine() =>
-        $"Delete Portal Row [ With dialog: {(WithDialog ? "Off" : "On")} ]";
+        $"Delete Portal Row [ With dialog: {(WithDialog ? "On" : "Off")} ]";
 
     public static new ScriptStep FromXml(XElement step)
     {
         var enabled = step.Attribute("enable")?.Value != "False";
-        var state = step.Element("NoInteract")?.Attribute("state")?.Value == "True";
+        var state = step.Element("NoInteract")?.Attribute("state")?.Value != "True";
         return new DeletePortalRowStep(state, enabled);
     }
 
diff --git a/src/SharpFM.Model/Scripting/Steps/DeleteRecordRequestStep.cs b/src/SharpFM.Model/Scripting/Steps/DeleteRecordRequestStep.cs
@@ -29,15 +29,15 @@ public override XElement ToXml() =>
             new XAttribute("id", XmlId),
             new XAttribute("name", XmlName),
             new XElement("NoInteract",
-                new XAttribute("state", WithDialog ? "True" : "False")));
+                new XAttribute("state", WithDialog ? "False" : "True")));
 
     public override string ToDisplayLine() =>
-        $"Delete Record/Request [ With dialog: {(WithDialog ? "Off" : "On")} ]";
+        $"Delete Record/Request [ With dialog: {(WithDialog ? "On" : "Off")} ]";
 
     public static new ScriptStep FromXml(XElement step)
     {
         var enabled = step.Attribute("enable")?.Value != "False";
-        var state = step.Element("NoInteract")?.Attribute("state")?.Value == "True";
+        var state = step.Element("NoInteract")?.Attribute("state")?.Value != "True";
         return new DeleteRecordRequestStep(state, enabled);
     }
 
diff --git a/src/SharpFM.Model/Scripting/Steps/DialPhoneStep.cs b/src/SharpFM.Model/Scripting/Steps/DialPhoneStep.cs
@@ -33,7 +33,7 @@ public override XElement ToXml() =>
             new XAttribute("enable", Enabled ? "True" : "False"),
             new XAttribute("id", XmlId),
             new XAttribute("name", XmlName),
-            new XElement("NoInteract", new XAttribute("state", WithDialog ? "True" : "False")),
+            new XElement("NoInteract", new XAttribute("state", WithDialog ? "False" : "True")),
             new XElement("UseDialPreferences", new XAttribute("value", UseDialPreferences ? "True" : "False")),
             Calculation.ToXml("Calculation"));
 
@@ -43,7 +43,7 @@ public override string ToDisplayLine() =>
     public static new ScriptStep FromXml(XElement step)
     {
         var enabled = step.Attribute("enable")?.Value != "False";
-        var withDialog_v = step.Element("NoInteract")?.Attribute("state")?.Value == "True";
+        var withDialog_v = step.Element("NoInteract")?.Attribute("state")?.Value != "True";
         var useDialPreferences_v = step.Element("UseDialPreferences")?.Attribute("value")?.Value == "True";
         var calculation_vEl = step.Element("Calculation");
         var calculation_v = calculation_vEl is not null ? Calculation.FromXml(calculation_vEl) : new Calculation("");
diff --git a/src/SharpFM.Model/Scripting/Steps/ExecuteSqlStep.cs b/src/SharpFM.Model/Scripting/Steps/ExecuteSqlStep.cs
@@ -26,7 +26,7 @@ public override XElement ToXml()
             new XAttribute("enable", Enabled ? "True" : "False"),
             new XAttribute("id", XmlId),
             new XAttribute("name", XmlName),
-            new XElement("NoInteract", new XAttribute("state", WithDialog ? "True" : "False")));
+            new XElement("NoInteract", new XAttribute("state", WithDialog ? "False" : "True")));
         if (Profile is not null) step.Add(Profile.ToXml());
         return step;
     }
@@ -43,7 +43,7 @@ public override string ToDisplayLine()
     public static new ScriptStep FromXml(XElement step)
     {
         var enabled = step.Attribute("enable")?.Value != "False";
-        var withDialog = step.Element("NoInteract")?.Attribute("state")?.Value == "True";
+        var withDialog = step.Element("NoInteract")?.Attribute("state")?.Value != "True";
         var profileEl = step.Element("Profile");
         var profile = profileEl is not null ? SqlProfile.FromXml(profileEl) : null;
         return new ExecuteSqlStep(withDialog, profile, enabled);
diff --git a/src/SharpFM.Model/Scripting/Steps/OmitMultipleRecordsStep.cs b/src/SharpFM.Model/Scripting/Steps/OmitMultipleRecordsStep.cs
@@ -30,7 +30,7 @@ public override XElement ToXml() =>
             new XAttribute("enable", Enabled ? "True" : "False"),
             new XAttribute("id", XmlId),
             new XAttribute("name", XmlName),
-            new XElement("NoInteract", new XAttribute("state", WithDialog ? "True" : "False")),
+            new XElement("NoInteract", new XAttribute("state", WithDialog ? "False" : "True")),
             Calculation.ToXml("Calculation"));
 
     public override string ToDisplayLine() =>
@@ -39,7 +39,7 @@ public override string ToDisplayLine() =>
     public static new ScriptStep FromXml(XElement step)
     {
         var enabled = step.Attribute("enable")?.Value != "False";
-        var withDialog_v = step.Element("NoInteract")?.Attribute("state")?.Value == "True";
+        var withDialog_v = step.Element("NoInteract")?.Attribute("state")?.Value != "True";
         var calculation_vEl = step.Element("Calculation");
         var calculation_v = calculation_vEl is not null ? Calculation.FromXml(calculation_vEl) : new Calculation("");
         return new OmitMultipleRecordsStep(withDialog_v, calculation_v, enabled);
diff --git a/src/SharpFM.Model/Scripting/Steps/OpenURLStep.cs b/src/SharpFM.Model/Scripting/Steps/OpenURLStep.cs
@@ -33,7 +33,7 @@ public override XElement ToXml() =>
             new XAttribute("enable", Enabled ? "True" : "False"),
             new XAttribute("id", XmlId),
             new XAttribute("name", XmlName),
-            new XElement("NoInteract", new XAttribute("state", WithDialog ? "True" : "False")),
+            new XElement("NoInteract", new XAttribute("state", WithDialog ? "False" : "True")),
             new XElement("Option", new XAttribute("state", InExternalBrowser ? "True" : "False")),
             Calculation.ToXml("Calculation"));
 
@@ -43,7 +43,7 @@ public override string ToDisplayLine() =>
     public static new ScriptStep FromXml(XElement step)
     {
         var enabled = step.Attribute("enable")?.Value != "False";
-        var withDialog_v = step.Element("NoInteract")?.Attribute("state")?.Value == "True";
+        var withDialog_v = step.Element("NoInteract")?.Attribute("state")?.Value != "True";
         var inExternalBrowser_v = step.Element("Option")?.Attribute("state")?.Value == "True";
         var calculation_vEl = step.Element("Calculation");
         var calculation_v = calculation_vEl is not null ? Calculation.FromXml(calculation_vEl) : new Calculation("");
diff --git a/src/SharpFM.Model/Scripting/Steps/ReLoginStep.cs b/src/SharpFM.Model/Scripting/Steps/ReLoginStep.cs
@@ -33,7 +33,7 @@ public override XElement ToXml() =>
             new XAttribute("enable", Enabled ? "True" : "False"),
             new XAttribute("id", XmlId),
             new XAttribute("name", XmlName),
-            new XElement("NoInteract", new XAttribute("state", WithDialog ? "True" : "False")),
+            new XElement("NoInteract", new XAttribute("state", WithDialog ? "False" : "True")),
             new XElement("AccountName", AccountName.ToXml("Calculation")),
             new XElement("Password", Password.ToXml("Calculation")));
 
@@ -43,7 +43,7 @@ public override string ToDisplayLine() =>
     public static new ScriptStep FromXml(XElement step)
     {
         var enabled = step.Attribute("enable")?.Value != "False";
-        var withDialog_v = step.Element("NoInteract")?.Attribute("state")?.Value == "True";
+        var withDialog_v = step.Element("NoInteract")?.Attribute("state")?.Value != "True";
         var accountName_vWrapEl = step.Element("AccountName");
         var accountName_vCalcEl = accountName_vWrapEl?.Element("Calculation");
         var accountName_v = accountName_vCalcEl is not null ? Calculation.FromXml(accountName_vCalcEl) : new Calculation("");
diff --git a/src/SharpFM.Model/Scripting/Steps/RecoverFileStep.cs b/src/SharpFM.Model/Scripting/Steps/RecoverFileStep.cs
@@ -29,7 +29,7 @@ public override XElement ToXml() =>
             new XAttribute("enable", Enabled ? "True" : "False"),
             new XAttribute("id", XmlId),
             new XAttribute("name", XmlName),
-            new XElement("NoInteract", new XAttribute("state", WithDialog ? "True" : "False")),
+            new XElement("NoInteract", new XAttribute("state", WithDialog ? "False" : "True")),
             new XElement("UniversalPathList", UniversalPathList));
 
     public override string ToDisplayLine() =>
@@ -38,7 +38,7 @@ public override string ToDisplayLine() =>
     public static new ScriptStep FromXml(XElement step)
     {
         var enabled = step.Attribute("enable")?.Value != "False";
-        var withDialog_v = step.Element("NoInteract")?.Attribute("state")?.Value == "True";
+        var withDialog_v = step.Element("NoInteract")?.Attribute("state")?.Value != "True";
         var universalPathList_v = step.Element("UniversalPathList")?.Value ?? "";
         return new RecoverFileStep(withDialog_v, universalPathList_v, enabled);
     }
diff --git a/src/SharpFM.Model/Scripting/Steps/RelookupFieldContentsStep.cs b/src/SharpFM.Model/Scripting/Steps/RelookupFieldContentsStep.cs
@@ -29,7 +29,7 @@ public override XElement ToXml() =>
             new XAttribute("enable", Enabled ? "True" : "False"),
             new XAttribute("id", XmlId),
             new XAttribute("name", XmlName),
-            new XElement("NoInteract", new XAttribute("state", WithDialog ? "True" : "False")),
+            new XElement("NoInteract", new XAttribute("state", WithDialog ? "False" : "True")),
             Target.ToXml("Field"));
 
     public override string ToDisplayLine() =>
@@ -38,7 +38,7 @@ public override string ToDisplayLine() =>
     public static new ScriptStep FromXml(XElement step)
     {
         var enabled = step.Attribute("enable")?.Value != "False";
-        var withDialog_v = step.Element("NoInteract")?.Attribute("state")?.Value == "True";
+        var withDialog_v = step.Element("NoInteract")?.Attribute("state")?.Value != "True";
         var fieldEl = step.Element("Field");
         var target = fieldEl is not null ? FieldRef.FromXml(fieldEl) : FieldRef.ForField("", 0, "");
         return new RelookupFieldContentsStep(withDialog_v, target, enabled);
diff --git a/src/SharpFM.Model/Scripting/Steps/ReplaceFieldContentsStep.cs b/src/SharpFM.Model/Scripting/Steps/ReplaceFieldContentsStep.cs
@@ -45,7 +45,7 @@ public override XElement ToXml()
             new XAttribute("enable", Enabled ? "True" : "False"),
             new XAttribute("id", XmlId),
             new XAttribute("name", XmlName),
-            new XElement("NoInteract", new XAttribute("state", WithDialog ? "True" : "False")),
+            new XElement("NoInteract", new XAttribute("state", WithDialog ? "False" : "True")),
             new XElement("With", new XAttribute("value", Mode)));
         if (Calculation is not null) step.Add(Calculation.ToXml("Calculation"));
         if (SerialOptions is not null) step.Add(SerialOptions.ToXml());
@@ -75,7 +75,7 @@ public override string ToDisplayLine()
     public static new ScriptStep FromXml(XElement step)
     {
         var enabled = step.Attribute("enable")?.Value != "False";
-        var withDialog = step.Element("NoInteract")?.Attribute("state")?.Value == "True";
+        var withDialog = step.Element("NoInteract")?.Attribute("state")?.Value != "True";
         var mode = step.Element("With")?.Attribute("value")?.Value ?? "Calculation";
         var calcEl = step.Element("Calculation");
         var calc = calcEl is not null ? Values.Calculation.FromXml(calcEl) : null;
diff --git a/src/SharpFM.Model/Scripting/Steps/RevertRecordRequestStep.cs b/src/SharpFM.Model/Scripting/Steps/RevertRecordRequestStep.cs
@@ -29,15 +29,15 @@ public override XElement ToXml() =>
             new XAttribute("id", XmlId),
             new XAttribute("name", XmlName),
             new XElement("NoInteract",
-                new XAttribute("state", WithDialog ? "True" : "False")));
+                new XAttribute("state", WithDialog ? "False" : "True")));
 
     public override string ToDisplayLine() =>
-        $"Revert Record/Request [ With dialog: {(WithDialog ? "Off" : "On")} ]";
+        $"Revert Record/Request [ With dialog: {(WithDialog ? "On" : "Off")} ]";
 
     public static new ScriptStep FromXml(XElement step)
     {
         var enabled = step.Attribute("enable")?.Value != "False";
-        var state = step.Element("NoInteract")?.Attribute("state")?.Value == "True";
+        var state = step.Element("NoInteract")?.Attribute("state")?.Value != "True";
         return new RevertRecordRequestStep(state, enabled);
     }
 
diff --git a/src/SharpFM.Model/Scripting/Steps/TriggerClarisConnectFlowStep.cs b/src/SharpFM.Model/Scripting/Steps/TriggerClarisConnectFlowStep.cs
@@ -55,7 +55,7 @@ public override XElement ToXml()
             new XAttribute("enable", Enabled ? "True" : "False"),
             new XAttribute("id", XmlId),
             new XAttribute("name", XmlName),
-            new XElement("NoInteract", new XAttribute("state", WithDialog ? "True" : "False")),
+            new XElement("NoInteract", new XAttribute("state", WithDialog ? "False" : "True")),
             new XElement("DontEncodeURL", new XAttribute("state", DontEncodeUrl ? "True" : "False")),
             new XElement("SelectAll", new XAttribute("state", SelectAll ? "True" : "False")),
             new XElement("VerifySSLCertificates", new XAttribute("state", VerifySslCertificates ? "True" : "False")),
@@ -80,7 +80,7 @@ public override string ToDisplayLine()
     public static new ScriptStep FromXml(XElement step)
     {
         var enabled = step.Attribute("enable")?.Value != "False";
-        var withDialog = step.Element("NoInteract")?.Attribute("state")?.Value == "True";
+        var withDialog = step.Element("NoInteract")?.Attribute("state")?.Value != "True";
         var dontEncode = step.Element("DontEncodeURL")?.Attribute("state")?.Value == "True";
         var selectAll = step.Element("SelectAll")?.Attribute("state")?.Value == "True";
         var verify = step.Element("VerifySSLCertificates")?.Attribute("state")?.Value == "True";
diff --git a/src/SharpFM.Model/Scripting/Steps/TruncateTableStep.cs b/src/SharpFM.Model/Scripting/Steps/TruncateTableStep.cs
@@ -40,7 +40,7 @@ public override XElement ToXml()
             new XAttribute("enable", Enabled ? "True" : "False"),
             new XAttribute("id", XmlId),
             new XAttribute("name", XmlName),
-            new XElement("NoInteract", new XAttribute("state", WithDialog ? "True" : "False")),
+            new XElement("NoInteract", new XAttribute("state", WithDialog ? "False" : "True")),
             baseTable);
     }
 
@@ -50,7 +50,7 @@ public override string ToDisplayLine() =>
     public static new ScriptStep FromXml(XElement step)
     {
         var enabled = step.Attribute("enable")?.Value != "False";
-        var withDialog = step.Element("NoInteract")?.Attribute("state")?.Value == "True";
+        var withDialog = step.Element("NoInteract")?.Attribute("state")?.Value != "True";
         var tableEl = step.Element("BaseTable");
         var table = tableEl is not null ? NamedRef.FromXml(tableEl) : new NamedRef(-1, "<Current Table>");
         var comment = tableEl?.Attribute("comment")?.Value;
diff --git a/tests/SharpFM.Tests/Scripting/Steps/NoInteractSemanticTests.cs b/tests/SharpFM.Tests/Scripting/Steps/NoInteractSemanticTests.cs
diff --git a/tests/SharpFM.Tests/Scripting/Steps/ReplaceFieldContentsStepTests.cs b/tests/SharpFM.Tests/Scripting/Steps/ReplaceFieldContentsStepTests.cs
diff --git a/tests/SharpFM.Tests/Scripting/Steps/TruncateTableStepTests.cs b/tests/SharpFM.Tests/Scripting/Steps/TruncateTableStepTests.cs
