Conversation
| val excludedPatterns = (listOf( | ||
| ".git", ".hg", ".svn", // Version control systems | ||
| ".idea", ".idea_modules", ".vs", ".vscode", ".code-workspace", ".settings", // IDEs | ||
| "bazel-*", "bin", "build", "node_modules", "target", // Build systems |
There was a problem hiding this comment.
Hm, I would rather integrate with .gitignore or a custom file (e.g. .klsignore) than adding to this ever-growing list of hardcoded directories... my worry is that directory names like target are already so generic, that there might be non-Maven-projects that place their source code there, for example
There was a problem hiding this comment.
Yeah, i noticed your TODO for it, and this is really a problem
I'm not sure about reading .gitignore, because some autogenerated files may be ignored, but should be loaded as sources - just like you worry about target.
Consider this PR more like "hotfix" rather than solid improvement:)
There was a problem hiding this comment.
Yeah I agree, in the long term we have got to come up with a proper solution... but for now this fix shouldn't hurt.
|
I've attempted that "proper solution" here #574 which is ready for review. |
3 participants
Fixes #294 (partly): Selectively exclude hidden directories instead of all hidden files and dirs (mainly, to make it easier to work with Teamcity Kotlin DSL)