Add textDocument/implementation support#670
Open
TheLazyLemur wants to merge 1 commit into
Open
Conversation
Wire up implementationProvider capability and handler. Resolve declarations at cursor via DECLARATION_TO_DESCRIPTOR fallback when no reference expression exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Recently started working with Kotlin and realised the server doesn't support go-to-implementation, which is a deal breaker for navigating interfaces and abstract classes.
Summary
implementationProviderserver capabilitytextDocument/implementationhandler inKotlinTextDocumentServiceFindImplementations— finds concrete implementations of interfaces, abstract classes, and their membersDECLARATION_TO_DESCRIPTORwhen cursor is on a declaration (not a reference), sogiworks aftergdto an interfaceTest plan
./gradlew :server:buildpassesImplementationTestcovers interface/abstract class resolutiongdto interface declaration,gireturns implementing classes