From 771753e88d606c10798dc0fb9fb4a09a16e5a483 Mon Sep 17 00:00:00 2001
From: Jack <jrmeyer339@gmail.com>
Date: Thu, 26 Mar 2026 22:04:02 +1100
Subject: [PATCH] add test to ci for PRs and remove invalid test

---
 .github/workflows/test.yml  |  2 +-
 pkg/launcher/custom_test.go | 11 -----------
 2 files changed, 1 insertion(+), 12 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index ad9ffa87..e8558fc6 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -1,6 +1,6 @@
 name: CI
 
-on: [push]
+on: [push, pull_request]
 
 jobs:
   test:
diff --git a/pkg/launcher/custom_test.go b/pkg/launcher/custom_test.go
index 6adf1f32..1cf9efe8 100644
--- a/pkg/launcher/custom_test.go
+++ b/pkg/launcher/custom_test.go
@@ -35,17 +35,6 @@ func TestCustom_LaunchCommand(t *testing.T) {
 			},
 			want: []string{"/usr/bin/firefox", "--url", "https://commonfate.io", "--profile", "example"},
 		},
-		{
-			name: "empty_profile",
-			fields: fields{
-				Command: "/usr/bin/firefox --url {{.URL}} --profile {{.Profile}}",
-			},
-			args: args{
-				url:     "https://commonfate.io",
-				profile: "",
-			},
-			want: []string{"/usr/bin/firefox", "--url", "https://commonfate.io", "--profile", ""},
-		},
 		{
 			name: "with_args",
 			fields: fields{