Skip to content

Fix build on modern CMake 4 / pybind11 / conda toolchains #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Wenri wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix build on modern CMake 4 / pybind11 / conda toolchains #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c31016
Fix manifold target_compile_options passing CMAKE_CXX_FLAGS as one arg
Wenri Jun 23, 2026
9c96195
Pin build-time CMake < 4
Wenri Jun 23, 2026
a4242b2
Use pybind11 dtype::itemsize() instead of removed elsize()
Wenri Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,9 @@ set_target_properties(manifold PROPERTIES LINKER_LANGUAGE CXX)
target_include_directories(manifold PUBLIC ${MANIFOLD_SRC_DIR})
target_include_directories(manifold PRIVATE ${EXTERNAL_DEP_DIR}/manifold/3rd)
if (CMAKE_BUILD_TYPE STREQUAL "Debug")
target_compile_options(manifold PRIVATE "${CMAKE_CXX_FLAGS} -Wall -pthread -DWITH_OMP -Wno-int-in-bool-context -Wsign-compare -fsanitize=address")
target_compile_options(manifold PRIVATE -Wall -pthread -DWITH_OMP -Wno-int-in-bool-context -Wsign-compare -fsanitize=address)
else()
target_compile_options(manifold PRIVATE "${CMAKE_CXX_FLAGS} -DWITH_OMP ")
target_compile_options(manifold PRIVATE -DWITH_OMP)
endif()


Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[build-system]
requires = ["setuptools>=42", "wheel", "scipy", "numpy", "cmake>=3.2"]
requires = ["setuptools>=42", "wheel", "scipy", "numpy", "cmake>=3.2,<4"]
build-backend = "setuptools.build_meta"
2 changes: 1 addition & 1 deletion src/common/ply_loader.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ pybind11::array ply_data_to_array(std::shared_ptr<tinyply::PlyData> attrib) {
if (attrib->count == 0) {
return pybind11::array(attrib_dtype, std::vector<size_t>({0, 0}));
}
size_t bytes_per_scalar = attrib_dtype.elsize();
size_t bytes_per_scalar = attrib_dtype.itemsize();
if (bytes_per_scalar <= 0) {
throw std::runtime_error("Internal PLY loading error. Type has no defined byte size.");
}
Expand Down