Merge pull request #708 from hyphacoop/negative-zero

fxamacker · web-flow · commit d17f6c1bd3ae · 2025-09-15T21:33:10.000-05:00
Use actual negative zero in tests
diff --git a/decode_test.go b/decode_test.go
@@ -2085,8 +2085,8 @@ var unmarshalFloatTests = []unmarshalFloatTest{
 	},
 	{
 		data:               mustHexDecode("f98000"),
-		wantInterfaceValue: float64(-0.0),                       //nolint:staticcheck // we know -0.0 is 0.0 in Go
-		wantValues:         []any{float32(-0.0), float64(-0.0)}, //nolint:staticcheck // we know -0.0 is 0.0 in Go
+		wantInterfaceValue: math.Copysign(0, -1),
+		wantValues:         []any{float32(math.Copysign(0, -1)), math.Copysign(0, -1)},
 	},
 	{
 		data:               mustHexDecode("f93c00"),

Original file line number	Diff line number	Diff line change
`@@ -2085,8 +2085,8 @@ var unmarshalFloatTests = []unmarshalFloatTest{`
`2085`	`2085`	`},`
`2086`	`2086`	`{`
`2087`	`2087`	`data: mustHexDecode("f98000"),`
`2088`		`- wantInterfaceValue: float64(-0.0), //nolint:staticcheck // we know -0.0 is 0.0 in Go`
`2089`		`- wantValues: []any{float32(-0.0), float64(-0.0)}, //nolint:staticcheck // we know -0.0 is 0.0 in Go`
	`2088`	`+ wantInterfaceValue: math.Copysign(0, -1),`
	`2089`	`+ wantValues: []any{float32(math.Copysign(0, -1)), math.Copysign(0, -1)},`
`2090`	`2090`	`},`
`2091`	`2091`	`{`
`2092`	`2092`	`data: mustHexDecode("f93c00"),`