Skip to content

Commit dcd80e4

Browse files
committed
fix(ui): hide empty changes badge while loading
1 parent 26959d0 commit dcd80e4

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

ui/src/components/changes/__tests__/gitChangesSummary.test.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ describe('gitChangesSummary', () => {
223223
).toBe('');
224224
});
225225

226-
it('formats pending badge deltas and keeps loading badges visible', () => {
226+
it('formats pending badge deltas and hides zero-valued loading badges', () => {
227227
expect(formatGitChangesBadgeDelta('+', null)).toBe('+?');
228228
expect(formatGitChangesBadgeDelta('-', 4)).toBe('-4');
229229

@@ -234,6 +234,14 @@ describe('gitChangesSummary', () => {
234234
deletions: 0,
235235
pending: true,
236236
})
237+
).toBe(false);
238+
expect(
239+
shouldShowGitChangesBadge({
240+
count: 1,
241+
additions: null,
242+
deletions: null,
243+
pending: true,
244+
})
237245
).toBe(true);
238246
expect(
239247
shouldShowGitChangesBadge({

ui/src/components/changes/gitChangesSummary.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,5 +135,5 @@ export function shouldShowGitChangesBadge(summary: GitChangesBadgeSummary | null
135135
if (!summary) {
136136
return false;
137137
}
138-
return summary.pending || summary.count > 0;
138+
return summary.count > 0;
139139
}

0 commit comments

Comments
 (0)