Skip to content

Commit b763668

Browse files
fyalavuzclaude
andcommitted
fix: CI workflow Playwright install order + ecommerce aria-label
Move Playwright browser install before turbo test to prevent E2E failures in CI. Add missing aria-label="Add to cart" on floating cart button for E2E test compatibility. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 024379a commit b763668

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

.github/workflows/ci.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,11 @@ jobs:
1717
node-version: 20
1818
cache: pnpm
1919
- run: pnpm install --frozen-lockfile
20+
- name: Install Playwright browsers
21+
run: cd e2e && pnpm exec playwright install --with-deps chromium
2022
- run: pnpm turbo build
21-
- run: pnpm turbo test
2223
- run: pnpm turbo lint
23-
- name: Install Playwright
24-
run: cd e2e && pnpm exec playwright install --with-deps chromium
25-
- name: Run E2E tests
26-
run: cd e2e && pnpm test
24+
- run: pnpm turbo test
2725
- uses: actions/upload-artifact@v4
2826
if: failure()
2927
with:

apps/examples/app/ecommerce/page.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ export default function EcommerceExample() {
274274
</Content>
275275

276276
<Footer variant="floating" position="right">
277-
<button className="relative flex items-center justify-center size-14 rounded-full bg-primary text-primary-foreground shadow-xl hover:scale-105 transition-transform">
277+
<button aria-label="Add to cart" className="relative flex items-center justify-center size-14 rounded-full bg-primary text-primary-foreground shadow-xl hover:scale-105 transition-transform">
278278
<ShoppingCart className="size-6" />
279279
<span className="absolute -top-1 -right-1 flex h-5 min-w-5 items-center justify-center rounded-full bg-destructive px-1 text-[11px] font-bold text-white">
280280
3

0 commit comments

Comments
 (0)