Add missing error handling for ecdh session

Author: anhthii

cmd/mpcium/main.go

@@ -31,7 +31,7 @@ import (
 )
 
 const (
-	Version                    = "0.3.1"
+	Version                    = "0.3.2"
 	DefaultBackupPeriodSeconds = 300 // (5 minutes)
 )
 

pkg/identity/identity.go

@@ -484,7 +484,7 @@ func (s *fileStore) VerifySignature(msg *types.ECDHMessage) error {
 
 	// Verify the signature
 	if !ed25519.Verify(senderPk, msgBytes, msg.Signature) {
-		return fmt.Errorf("invalid signature")
+		return fmt.Errorf("invalid signature from %s with public key %s", msg.From, hex.EncodeToString(senderPk))
 	}
 
 	return nil

pkg/mpc/registry.go

@@ -72,7 +72,7 @@ func NewRegistry(
 		logger.Fatal("mpc_threshold must be greater than 0", nil)
 	}
 
-	return &registry{
+	reg := &registry{
 		consulKV:      consulKV,
 		nodeID:        nodeID,
 		peerNodeIDs:   getPeerIDsExceptSelf(nodeID, peerNodeIDs),
@@ -84,6 +84,10 @@ func NewRegistry(
 		ecdhSession:   ecdhSession,
 		mpcThreshold:  mpcThreshold,
 	}
+
+	go reg.consumeECDHErrors()
+
+	return reg
 }
 
 func getPeerIDsExceptSelf(nodeID string, peerNodeIDs []string) []string {
@@ -160,7 +164,7 @@ func (r *registry) Ready() error {
 
 	_, err = r.healthCheck.Listen(r.composeHealthCheckTopic(r.nodeID), func(data []byte) {
 		peerID, isEcdhReady, _ := parseHealthDataSplit(string(data))
-		logger.Debug("Health check ok", "peerID", peerID)
+		logger.Debug("Health check ok", "peerID", peerID, "isEcdhReady", isEcdhReady)
 		if !isEcdhReady {
 			logger.Info("[ECDH exchange retriggerd] not all peers are ready", "peerID", peerID)
 			go r.triggerECDHExchange()
@@ -367,9 +371,16 @@ func parseHealthDataSplit(s string) (peerID string, ready bool, err error) {
 	}
 
 	peerID = parts[0]
-	ready, err = strconv.ParseBool(parts[1]) // accepts "true"/"false", "1"/"0", "t"/"f"
+	ready, err = strconv.ParseBool(parts[1])
 	if err != nil {
 		return "", false, err
 	}
 	return peerID, ready, nil
 }
+
+// consumeECDHErrors consumes errors from ECDH session and logs them
+func (r *registry) consumeECDHErrors() {
+	for err := range r.ecdhSession.ErrChan() {
+		logger.Error("ECDH error", err)
+	}
+}