Fix lint issue

Author: anhthii

cmd/mpcium/main.go

@@ -181,7 +181,9 @@ func runNode(ctx context.Context, c *cli.Command) error {
 	signingConsumer := eventconsumer.NewSigningConsumer(natsConn, signingStream, pubsub, peerRegistry)
 
 	// Make the node ready before starting the signing consumer
-	peerRegistry.Ready()
+	if err := peerRegistry.Ready(); err != nil {
+		logger.Error("Failed to mark peer registry as ready", err)
+	}
 
 	appContext, cancel := context.WithCancel(context.Background())
 	// Setup signal handling to cancel context on termination signals.
@@ -247,7 +249,9 @@ func promptForSensitiveCredentials() {
 	// Prompt for initiator public key (using regular input since it's not as sensitive)
 	var initiatorKey string
 	fmt.Print("Enter event initiator public key (hex): ")
-	fmt.Scanln(&initiatorKey)
+	if _, err := fmt.Scanln(&initiatorKey); err != nil {
+		logger.Fatal("Failed to read initiator key", err)
+	}
 
 	if initiatorKey == "" {
 		logger.Fatal("Initiator public key cannot be empty", nil)

e2e/config.test.yaml.template

@@ -0,0 +1,11 @@
+badger_password: "{{.BadgerPassword}}"
+consul:
+  address: localhost:8501
+db_path: ./test_db
+environment: development
+event_initiator_pubkey: "{{.EventInitiatorPubkey}}"
+max_concurrent_keygen: 1
+mpc_threshold: 2
+mpcium_version: 1.0.0
+nats:
+  url: nats://localhost:4223 

e2e/keygen_test.go

@@ -132,7 +132,10 @@ func waitForConsulReady(address string, timeout time.Duration) error {
 	for time.Now().Before(deadline) {
 		resp, err := http.Get(fmt.Sprintf("http://%s/v1/status/leader", address))
 		if err == nil && resp.StatusCode == http.StatusOK {
-			resp.Body.Close()
+			if err := resp.Body.Close(); err != nil {
+				// Log the error but don't fail the check since the main goal is achieved
+				fmt.Printf("Warning: failed to close response body: %v\n", err)
+			}
 			return nil
 		}
 		time.Sleep(1 * time.Second)
@@ -590,7 +593,9 @@ func (s *E2ETestSuite) checkKeyInAllNodes(t *testing.T, walletID, keyType, keyNa
 			}
 
 			// Close recovery DB and try read-only again
-			recoveryDB.Close()
+			if err := recoveryDB.Close(); err != nil {
+				t.Logf("Warning: failed to close recovery database for %s: %v", nodeName, err)
+			}
 			time.Sleep(1 * time.Second)
 
 			db, err = badger.Open(opts)
@@ -644,7 +649,9 @@ func (s *E2ETestSuite) checkKeyInAllNodes(t *testing.T, walletID, keyType, keyNa
 		assert.NoError(t, err, "Failed to get %s key for wallet %s from node %s", keyName, walletID, nodeName)
 		assert.NotEmpty(t, data, "Missing %s key for wallet %s in node %s", keyName, walletID, nodeName)
 
-		kvStore.Close()
+		if err := kvStore.Close(); err != nil {
+			t.Logf("Warning: failed to close kvStore for %s: %v", nodeName, err)
+		}
 	}
 }
 

pkg/eventconsumer/event_consumer.go

@@ -721,14 +721,6 @@ func (ec *eventConsumer) addSession(walletID, txID string) {
 	ec.sessionsLock.Unlock()
 }
 
-// Remove a session from tracking
-func (ec *eventConsumer) removeSession(walletID, txID string) {
-	sessionID := fmt.Sprintf("%s-%s", walletID, txID)
-	ec.sessionsLock.Lock()
-	delete(ec.activeSessions, sessionID)
-	ec.sessionsLock.Unlock()
-}
-
 // checkAndTrackSession checks if a session already exists and tracks it if new.
 // Returns true if the session is a duplicate.
 func (ec *eventConsumer) checkDuplicateSession(walletID, txID string) bool {

pkg/identity/identity.go

@@ -4,6 +4,7 @@ import (
 	"crypto/ed25519"
 	"encoding/hex"
 	"encoding/json"
+	"errors"
 	"fmt"
 	"io"
 	"os"
@@ -252,8 +253,8 @@ func (s *fileStore) VerifyInitiatorMessage(msg types.InitiatorMessage) error {
 
 	// Get the signature
 	signature := msg.Sig()
-	if signature == nil || len(signature) == 0 {
-		return fmt.Errorf("message has no signature")
+	if len(signature) == 0 {
+		return errors.New("signature is empty")
 	}
 
 	// Verify the signature using the initiator's public key

pkg/logger/logger_test.go

@@ -134,11 +134,9 @@ func TestInfof_FormattedMessage(t *testing.T) {
 }
 
 func TestError_PanicsOnOddKeyValues(t *testing.T) {
-	// Capture log output
-	var buf bytes.Buffer
-	Log = zerolog.New(&buf).With().Timestamp().Logger()
+	Init("test", false)
 
 	assert.Panics(t, func() {
-		Error("test error", nil, "odd_key") // odd number of key-value pairs
+		Error("test error", nil, "odd_key", "value", "another_odd_key") //nolint:staticcheck // intentionally testing odd number of key-value pairs
 	})
-}
+}

pkg/messaging/message_queue.go

@@ -130,12 +130,16 @@ func (mq *msgQueue) Dequeue(topic string, handler func(message []byte) error) er
 		if err != nil {
 			if errors.Is(err, ErrPermament) {
 				logger.Info("Permanent error on message", "meta", meta)
-				msg.Term()
+				if err := msg.Term(); err != nil {
+					logger.Error("Failed to terminate message", err)
+				}
 				return
 			}
 
 			logger.Error("Error handling message: ", err)
-			msg.Nak()
+			if err := msg.Nak(); err != nil {
+				logger.Error("Failed to nak message", err)
+			}
 			return
 		}
 
@@ -155,7 +159,3 @@ func (mq *msgQueue) Close() {
 		mq.consumerContext.Stop()
 	}
 }
-
-func (n *msgQueue) handleReconnect(nc *nats.Conn) {
-	logger.Info("NATS: Reconnected to NATS")
-}

pkg/messaging/point2point.go

@@ -47,7 +47,9 @@ func (d *natsDirectMessaging) Send(id string, message []byte) error {
 func (d *natsDirectMessaging) Listen(id string, handler func(data []byte)) (Subscription, error) {
 	sub, err := d.natsConn.Subscribe(id, func(m *nats.Msg) {
 		handler(m.Data)
-		m.Respond([]byte("OK"))
+		if err := m.Respond([]byte("OK")); err != nil {
+			logger.Error("Failed to respond to message", err)
+		}
 	})
 	if err != nil {
 		return nil, err

pkg/types/initiator_msg.go

@@ -6,7 +6,7 @@ type KeyType string
 
 const (
 	KeyTypeSecp256k1 KeyType = "secp256k1"
-	KeyTypeEd25519           = "ed25519"
+	KeyTypeEd25519   KeyType = "ed25519"
 )
 
 // InitiatorMessage is anything that carries a payload to verify and its signature.

scripts/migration/add-key-type/main.go

@@ -27,34 +27,42 @@ func main() {
 		logger.Fatal("Failed to create badger kv store", err)
 	}
 
-	err = badgerKv.DB.View(func(txn *badger.Txn) error {
+	if err := badgerKv.DB.View(func(txn *badger.Txn) error {
 		opts := badger.DefaultIteratorOptions
-		opts.PrefetchValues = false
+		opts.PrefetchSize = 10
 		it := txn.NewIterator(opts)
 		defer it.Close()
 
 		for it.Rewind(); it.Valid(); it.Next() {
 			item := it.Item()
 			key := item.Key()
 			var result []byte
-			item.Value(func(val []byte) error {
-				result = append([]byte{}, val...)
+
+			if err := item.Value(func(val []byte) error {
+				result = append(result, val...)
 				return nil
-			})
+			}); err != nil {
+				return err
+			}
 
 			if !strings.HasPrefix(string(key), "eddsa:") {
 				if !strings.HasPrefix(string(key), "ecdsa:") {
-					badgerKv.DB.Update(func(txn *badger.Txn) error {
-						txn.Set([]byte(fmt.Sprintf("ecdsa:%s", key)), result)
-						txn.Delete(key)
-						return nil
-					})
+					if err := badgerKv.DB.Update(func(txn *badger.Txn) error {
+						if err := txn.Set([]byte(fmt.Sprintf("ecdsa:%s", key)), result); err != nil {
+							return err
+						}
+						return txn.Delete(key)
+					}); err != nil {
+						return err
+					}
 				}
-
 			}
 		}
 		return nil
-	})
+	}); err != nil {
+		logger.Fatal("Failed to migrate keys", err)
+	}
+
 	keys, err := badgerKv.Keys()
 	if err != nil {
 		logger.Fatal("Failed to get keys from badger kv store", err)