Skip to content

Commit d6d5229

Browse files
committed
Fix keygen topic
1 parent 1c13b3d commit d6d5229

5 files changed

Lines changed: 15 additions & 10 deletions

File tree

README.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,10 @@ At its cryptographic core, Mpcium integrates tss-lib, a production-grade thresho
3131
## Resources
3232

3333
- **MPC nodes architecture**: [MPC Fundamental and MPCIUM architecture](https://deepwiki.com/fystack/mpcium)
34-
- **MPC clients**:
34+
- **MPC clients**:
3535
- [TypeScript Client](https://github.com/fystack/mpcium-client-ts)
3636
- [Golang Client](https://github.com/fystack/mpcium/blob/master/pkg/client/client.go)
3737

38-
3938
![All node ready](images/all-node-ready.png)
4039

4140
## 📦 Dependencies Overview
@@ -164,13 +163,17 @@ func main () {
164163
```
165164

166165
### Testing
166+
167167
## 1. Unit tests
168+
168169
```
169170
go test ./... -v
170171
```
171172

172173
## 2. Integration tests
174+
173175
```
174176
cd e2e
175177
make test
176-
```
178+
```
179+

pkg/client/client.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ func (c *mpcClient) SignTransaction(msg *types.SignTxMessage) error {
235235
return fmt.Errorf("SignTransaction: marshal error: %w", err)
236236
}
237237

238-
if err := c.signingBroker.PublishMessage(context.Background(), event.SigningRequestEventTopic, bytes); err != nil {
238+
if err := c.signingBroker.PublishMessage(context.Background(), event.SigningRequestTopic, bytes); err != nil {
239239
return fmt.Errorf("SignTransaction: publish error: %w", err)
240240
}
241241
return nil

pkg/event/sign.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ const (
66
SigningRequestTopic = "mpc.signing_request.*"
77
SigningResultTopic = "mpc.mpc_signing_result.*"
88
SigningResultCompleteTopic = "mpc.mpc_signing_result.complete"
9-
SigningRequestEventTopic = "mpc.signing_request.event"
109
)
1110

1211
type SigningResultEvent struct {

pkg/event/types.go

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,11 @@ const (
5151
ErrorCodeMsgValidation ErrorCode = "ERROR_MSG_VALIDATION"
5252

5353
// Cryptographic operation errors
54-
ErrorCodeSignatureGeneration ErrorCode = "ERROR_SIGNATURE_GENERATION"
55-
ErrorCodeSignatureVerification ErrorCode = "ERROR_SIGNATURE_VERIFICATION"
56-
ErrorCodePreParamsGeneration ErrorCode = "ERROR_PRE_PARAMS_GENERATION"
57-
ErrorCodeTSSPartyCreation ErrorCode = "ERROR_TSS_PARTY_CREATION"
54+
ErrorCodeSignatureGeneration ErrorCode = "ERROR_SIGNATURE_GENERATION"
55+
ErrorCodeSignatureVerification ErrorCode = "ERROR_SIGNATURE_VERIFICATION"
56+
ErrorCodeInvalidInitiatorSignature ErrorCode = "ERROR_INVALID_INITIATOR_SIGNATURE"
57+
ErrorCodePreParamsGeneration ErrorCode = "ERROR_PRE_PARAMS_GENERATION"
58+
ErrorCodeTSSPartyCreation ErrorCode = "ERROR_TSS_PARTY_CREATION"
5859

5960
// Data serialization errors
6061
ErrorCodeMarshalFailure ErrorCode = "ERROR_MARSHAL_FAILURE"
@@ -134,6 +135,8 @@ func GetErrorCodeFromError(err error) ErrorCode {
134135
return ErrorCodeMessageDelivery
135136
case contains(errStr, "context", "cancelled"):
136137
return ErrorCodeContextCancelled
138+
case contains(errStr, "invalid signature from initiator"):
139+
return ErrorCodeInvalidInitiatorSignature
137140
default:
138141
return ErrorCodeUnknown
139142
}

pkg/eventconsumer/sign_consumer.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ func (sc *signingConsumer) Run(ctx context.Context) error {
9595
sub, err := sc.jsBroker.CreateSubscription(
9696
ctx,
9797
event.SigningConsumerStream,
98-
event.SigningRequestEventTopic,
98+
event.SigningRequestTopic,
9999
sc.handleSigningEvent,
100100
)
101101
if err != nil {

0 commit comments

Comments
 (0)