fix(setup): Enhance setup process and scripts#110
Merged
Conversation
- Update INSTALLATION.md to include execution permissions for setup.sh. - Add a new 'reset' target in the Makefile to clean the local environment. - Improve error handling and precondition checks in setup_identities.sh and setup_initiator.sh. - Modify setup.sh to execute scripts with proper permissions.
anhthii
reviewed
Oct 28, 2025
| sed -i '' -E "s|^([[:space:]]*event_initiator_pubkey:).*|\1 \"${PUBLIC_KEY}\"|" config.yaml | ||
| else | ||
| sed -i "s/event_initiator_pubkey: ./event_initiator_pubkey: "$PUBLIC_KEY"/" config.yaml | ||
| sed -i -E "s|^([[:space:]]*event_initiator_pubkey:).*|\1 \"${PUBLIC_KEY}\"|" config.yaml |
Contributor
There was a problem hiding this comment.
@Azzurriii is this compatiblefor both linux and macOS?
Contributor
Author
There was a problem hiding this comment.
Hi @anhthii It can. Tested on Darwin 24.x ARM. Please see
| # Add new line | ||
| echo "event_initiator_pubkey: \"$PUBLIC_KEY\"" >> config.yaml | ||
| printf '\n%s\n' "event_initiator_pubkey: \"${PUBLIC_KEY}\"" >> config.yaml | ||
| fi |
Contributor
There was a problem hiding this comment.
same question @Azzurriii is this compatiblefor both linux and macOS?
Contributor
|
cool thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes setup.sh to use execute (./) instead of source.
Updates INSTALLATION.md to add chmod +x for setup.sh.
Adds a make reset target to clean the local environment.
Improves error handling (set -euo pipefail) and adds precondition checks to setup_identities.sh and setup_initiator.sh.