Introduce conversion between chrono::NaiveDate and DateTime avoiding RustOpaque#2968
Introduce conversion between chrono::NaiveDate and DateTime avoiding RustOpaque#2968TrackerSB wants to merge 34 commits intofzyzcjy:masterfrom
Conversation
…b_internal generate-run-frb-codegen-command-generate --package frb_example/pure_dart"
|
As far as I can see meanwhile (since my last attempt) the PR template changed in the way that I should have made an example in dart_minimal. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2968 +/- ##
==========================================
- Coverage 98.34% 90.75% -7.60%
==========================================
Files 470 470
Lines 19428 18025 -1403
==========================================
- Hits 19106 16358 -2748
- Misses 322 1667 +1345 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
It is better to directly add things in pure_dart etc! :) |
|
I recognized that the regeneration of files resulted in automatically added explicit lifetime annotations. Is this expected, is it a problem, does it depend on the used Rust version? |
|
What next steps are left for me to do to make this PR worth to be merged? |
Feel free to make a separate PR to firstly update code for these!
I am sorry that I am having a very tight deadline recently :( I will try my best to find some time after the ddl to review and merge all pending PRs. At the same time, feel free to use your branch if you need this feature, as long as the critical tests in CI passes then usually the branch is good to use. |
…age frb_example/pure_dart_pde
…age frb_example/pure_dart
…age frb_example/integrate_third_party
|
@fzyzcjy , Please give this a release . |
|
@sumitsharansatsangi I have added some agent Skills a bit time ago, and plan to let agents help me do some updates to code when I review it. too busy recently but will handle it asap! |
|
Thanks for assurance, @fzyzcjy !!! |
…age frb_example/pure_dart
…age frb_example/pure_dart_pde
…age frb_example/integrate_third_party
generate-internal-frb-example-pure-dart && ./frb_internal generate-run-frb-codegen-command-generate --package frb_example/pure_dart && ./frb_internal generate-internal-frb-example-pure-dart-pde && ./frb_internal generate-run-frb-codegen-command-generate --package frb_example/pure_dart_pde && ./frb_internal precommit --mode fast
|
I merged origin/master trying to update my PR. |
|
hmm I guess maybe try to update the submodule btw I did plan to add sth like #3051 to make it easier to make CI pass. I have emergent ddl recently and cannot continue though :( |
|
This would be amazing. 👍🏻🏆 |
Changes
Fixes #1833
Procedure and Checklist
In order to quickly iterate and avoid slowing down development pace by making CI pass, only the following simplified steps are needed, and I (fzyzcjy) will handle the rest of CI / moving the tests currently (will have more automation in the future).
frb_example/dart_minimal.dart_minimal's CI green.Utility commands
cargo run --manifest-path /path/to/flutter_rust_bridge/frb_codegen/Cargo.toml -- generate./frb_internal test-dart-native --package frb_example/dart_minimal