Skip to content

Add precommit autofix workflow and patch artifact#3051

Open
fzyzcjy wants to merge 89 commits into
masterfrom
precommit_ci
Open

Add precommit autofix workflow and patch artifact#3051
fzyzcjy wants to merge 89 commits into
masterfrom
precommit_ci

Conversation

@fzyzcjy
Copy link
Copy Markdown
Owner

@fzyzcjy fzyzcjy commented Apr 4, 2026

This PR adds a CI remediation flow for generated and normalized file drift, and moves the dev-container automation behind focused frb_internal commands.

  • add a standalone Precommit Autofix workflow that produces a downloadable patch artifact instead of forcing contributors to reproduce the full environment locally
  • add frb_internal precommit-autofix-in-dev-container to run the autofix flow inside the published dev image
  • add frb_internal publish-dev-docker to own the dev image build/smoke-test/publish flow
  • keep Dockerfile version parsing as an internal library and remove no-longer-needed CLI/output plumbing
  • thin both GitHub workflows so they mainly provide GitHub-specific wiring
  • update contributor docs with the current dev image tag and the patch-apply workflow

I did not run tests in this branch.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces two new internal tools: dev-docker-metadata for extracting environment versions from Dockerfiles and precommit-autofix for generating git patches when precommit checks detect uncommitted changes. It also updates the contribution documentation and Docker image versions. Several critical compilation errors were identified in PrecommitAutofixService where an undefined method _commandRunner was used instead of the commandRunner field. Additionally, the regex for parsing Dockerfile arguments could be made more robust to handle varying whitespace.

Comment thread tools/frb_internal/lib/src/makefile_dart/precommit_autofix.dart Outdated
Comment thread tools/frb_internal/lib/src/makefile_dart/precommit_autofix.dart Outdated
Comment thread tools/frb_internal/lib/src/makefile_dart/precommit_autofix.dart Outdated
Comment thread tools/frb_internal/lib/src/makefile_dart/dev_docker_metadata.dart
fzyzcjy added 24 commits April 4, 2026 11:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 5, 2026

Precommit Autofix

Commit: 517bf0be695ec5177fcc55da3bcf5d7eab5b3b52
Run: 25621427636

CI produced no diff. The branch is already clean after precommit autofix.

@fzyzcjy
Copy link
Copy Markdown
Owner Author

fzyzcjy commented May 10, 2026

image

@fzyzcjy
Copy link
Copy Markdown
Owner Author

fzyzcjy commented May 10, 2026

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant