Skip to content

Commit fcd9aa6

Browse files
committed
pre-commit autoupdate and fixes
1 parent c2145d0 commit fcd9aa6

78 files changed

Lines changed: 809 additions & 169 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.pre-commit-config.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ repos:
2222
- id: trailing-whitespace
2323

2424
- repo: https://github.com/psf/black-pre-commit-mirror
25-
rev: "25.9.0"
25+
rev: "26.3.1"
2626
hooks:
2727
- id: black-jupyter
2828
args: ["--line-length", "100"]
@@ -34,19 +34,19 @@ repos:
3434
additional_dependencies: [black==23.3.0]
3535

3636
- repo: https://github.com/astral-sh/ruff-pre-commit
37-
rev: "v0.13.3"
37+
rev: "v0.15.12"
3838
hooks:
3939
- id: ruff
4040
args: ["--fix", "--show-fixes"]
4141

4242
- repo: https://github.com/mgedmin/check-manifest
43-
rev: "0.50"
43+
rev: "0.51"
4444
hooks:
4545
- id: check-manifest
4646
stages: [manual]
4747

4848
- repo: https://github.com/codespell-project/codespell
49-
rev: "v2.4.1"
49+
rev: "v2.4.2"
5050
hooks:
5151
- id: codespell
5252
args: ["-L", "commun,precess"]
@@ -76,7 +76,7 @@ repos:
7676
types_or: [yaml, markdown, html, css, scss, javascript, json]
7777

7878
- repo: https://github.com/kynan/nbstripout
79-
rev: "0.8.1"
79+
rev: "0.9.1"
8080
hooks:
8181
- id: nbstripout
8282
args:
@@ -87,7 +87,7 @@ repos:
8787
]
8888

8989
- repo: https://github.com/pre-commit/mirrors-clang-format
90-
rev: "v21.1.2"
90+
rev: "v22.1.4"
9191
hooks:
9292
- id: clang-format
9393
types_or: [c++, c, cuda]

examples/cbpm.py

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,11 @@ def Test(vis=False, interactive=False, gdml=True, fluka=False):
6868
"wg_sub3", wg_sub2, wg_cut_solid, [[0, 0, _np.pi], [-wg_centre, 0, 0]], reg
6969
)
7070
wg_sub4 = _g4.solid.Subtraction(
71-
"wg_sub4", wg_sub3, wg_cut_solid, [[0, 0, 3.0 / 2.0 * _np.pi], [0, -wg_centre, 0]], reg
71+
"wg_sub4",
72+
wg_sub3,
73+
wg_cut_solid,
74+
[[0, 0, 3.0 / 2.0 * _np.pi], [0, -wg_centre, 0]],
75+
reg,
7276
)
7377

7478
wg_sub5 = _g4.solid.Subtraction(
@@ -86,7 +90,12 @@ def Test(vis=False, interactive=False, gdml=True, fluka=False):
8690

8791
wg_logical = _g4.LogicalVolume(wg_sub8, "G4_Cu", "wg_logical", reg)
8892
wg_physical = _g4.PhysicalVolume(
89-
[0, 0, 0], [0, 0, -wg_length / 2.0], wg_logical, "wg_physical", world_logical, reg
93+
[0, 0, 0],
94+
[0, 0, -wg_length / 2.0],
95+
wg_logical,
96+
"wg_physical",
97+
world_logical,
98+
reg,
9099
)
91100

92101
################################
@@ -121,7 +130,12 @@ def Test(vis=False, interactive=False, gdml=True, fluka=False):
121130
ca_solid = _g4.solid.Tubs("ca_solid", ca_innerr, wg_outerr, ca_length, 0, 2 * _np.pi, reg)
122131
ca_logical = _g4.LogicalVolume(ca_solid, "G4_Cu", "ca_logical", reg)
123132
ca_physical = _g4.PhysicalVolume(
124-
[0, 0, 0], [0, 0, ca_length / 2.0 + safety], ca_logical, "ca_physical", world_logical, reg
133+
[0, 0, 0],
134+
[0, 0, ca_length / 2.0 + safety],
135+
ca_logical,
136+
"ca_physical",
137+
world_logical,
138+
reg,
125139
)
126140

127141
################################

examples/hep_detector.py

Lines changed: 103 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,12 @@ def HepDetector(siBarrel=True, siEndcaps=True, ecalBarrel=True, solenoid=True):
4141
for i in range(4):
4242
zOffset = 0.5 * siBarrelLength * 1.02 + (i * endcapLayerSeparation)
4343
pyg4ometry.geant4.PhysicalVolume(
44-
[0, 0, 0], [0, 0, zOffset], endcapLV, "endcap_" + str(i) + "_left_pv", worldLV, reg
44+
[0, 0, 0],
45+
[0, 0, zOffset],
46+
endcapLV,
47+
"endcap_" + str(i) + "_left_pv",
48+
worldLV,
49+
reg,
4550
)
4651
pyg4ometry.geant4.PhysicalVolume(
4752
[0, 0, 0],
@@ -113,7 +118,12 @@ def SiBarrelTracker(reg=None):
113118
name="barrelAv1", moduleAv=siTrackerModuleAv, radius=0.15, nAzimuth=15, reg=reg
114119
)
115120
siTrackerLayer1Pv = pyg4ometry.geant4.PhysicalVolume(
116-
[_np.pi / 2.0, 0, 0], [0, 0, 0], siTrackerLayer1Av, "siTrackerLayer1Pv", siTrackerLv, reg
121+
[_np.pi / 2.0, 0, 0],
122+
[0, 0, 0],
123+
siTrackerLayer1Av,
124+
"siTrackerLayer1Pv",
125+
siTrackerLv,
126+
reg,
117127
)
118128

119129
siTrackerLayer2Av = SiTrackerBarrelLayer(
@@ -124,7 +134,12 @@ def SiBarrelTracker(reg=None):
124134
reg=reg,
125135
)
126136
siTrackerLayer2Pv = pyg4ometry.geant4.PhysicalVolume(
127-
[_np.pi / 2.0, 0, 0], [0, 0, 0], siTrackerLayer2Av, "siTrackerLayer2Pv", siTrackerLv, reg
137+
[_np.pi / 2.0, 0, 0],
138+
[0, 0, 0],
139+
siTrackerLayer2Av,
140+
"siTrackerLayer2Pv",
141+
siTrackerLv,
142+
reg,
128143
)
129144

130145
siTrackerLayer3Av = SiTrackerBarrelLayer(
@@ -135,7 +150,12 @@ def SiBarrelTracker(reg=None):
135150
reg=reg,
136151
)
137152
siTrackerLayer3Pv = pyg4ometry.geant4.PhysicalVolume(
138-
[_np.pi / 2.0, 0, 0], [0, 0, 0], siTrackerLayer3Av, "siTrackerLayer3Pv", siTrackerLv, reg
153+
[_np.pi / 2.0, 0, 0],
154+
[0, 0, 0],
155+
siTrackerLayer3Av,
156+
"siTrackerLayer3Pv",
157+
siTrackerLv,
158+
reg,
139159
)
140160

141161
return siTrackerLv
@@ -180,7 +200,12 @@ def SiTrackerBarrelLayer(
180200

181201

182202
def SiTrackerBarrelModule(
183-
sensorSize=0.08, sensorGap=3e-3, pcbLength=0.015, pcbGap=0.005, tiltAngleDeg=5, reg=None
203+
sensorSize=0.08,
204+
sensorGap=3e-3,
205+
pcbLength=0.015,
206+
pcbGap=0.005,
207+
tiltAngleDeg=5,
208+
reg=None,
184209
):
185210
reg = pyg4ometry.geant4.Registry() if reg is None else reg
186211

@@ -272,7 +297,15 @@ def SiTrackerEndcapLayer(
272297
dAzimuth = 2 * _np.pi / nAzimuth
273298

274299
siTrackerECTubs = pyg4ometry.geant4.solid.Tubs(
275-
name + "_siTrackerECTubs", innerRadius, outerRadius, 0.025, 0, 2 * _np.pi, reg, "m", "rad"
300+
name + "_siTrackerECTubs",
301+
innerRadius,
302+
outerRadius,
303+
0.025,
304+
0,
305+
2 * _np.pi,
306+
reg,
307+
"m",
308+
"rad",
276309
)
277310
siTrackerECLv = pyg4ometry.geant4.LogicalVolume(
278311
siTrackerECTubs, "G4_Galactic", "siTrackerECLv", reg
@@ -310,10 +343,20 @@ def SiTrackerEndcapModule(
310343
)
311344

312345
sensorPv1 = pyg4ometry.geant4.PhysicalVolume(
313-
[0, 0, 0], [0, sensorGap / 2, 0, "m"], sensorLv, "sensorEndcapPv1", moduleAv, reg
346+
[0, 0, 0],
347+
[0, sensorGap / 2, 0, "m"],
348+
sensorLv,
349+
"sensorEndcapPv1",
350+
moduleAv,
351+
reg,
314352
)
315353
sensorPv2 = pyg4ometry.geant4.PhysicalVolume(
316-
[0, 0, 0], [0, -sensorGap / 2, 0, "m"], sensorLv, "sensorEndcapPv2", moduleAv, reg
354+
[0, 0, 0],
355+
[0, -sensorGap / 2, 0, "m"],
356+
sensorLv,
357+
"sensorEndcapPv2",
358+
moduleAv,
359+
reg,
317360
)
318361

319362
return moduleAv
@@ -346,7 +389,13 @@ def Solenoid(innerRadius, thickness, length, constants, reg=None):
346389
"""
347390
reg = pyg4ometry.geant4.Registry() if reg is None else reg
348391
solenoidSolid = pyg4ometry.geant4.solid.Tubs(
349-
"solenoid_solid", innerRadius, innerRadius + thickness, length, 0, constants["twopi"], reg
392+
"solenoid_solid",
393+
innerRadius,
394+
innerRadius + thickness,
395+
length,
396+
0,
397+
constants["twopi"],
398+
reg,
350399
)
351400
aluminium = pyg4ometry.geant4.MaterialPredefined("G4_Al")
352401
solenoidLV = pyg4ometry.geant4.LogicalVolume(solenoidSolid, aluminium, "solenoid_lv", reg)
@@ -358,7 +407,13 @@ def Solenoid(innerRadius, thickness, length, constants, reg=None):
358407
nCoils = int(length.eval() / (2 * coilLengthZ.eval()))
359408
nCoilsEven = nCoils if (nCoils % 2 == 0) else nCoils - 1
360409
coilSolid = pyg4ometry.geant4.solid.Tubs(
361-
"coil_solid", coilInnerRadius, coilOuterRadius, coilLengthZ, 0, constants["twopi"], reg
410+
"coil_solid",
411+
coilInnerRadius,
412+
coilOuterRadius,
413+
coilLengthZ,
414+
0,
415+
constants["twopi"],
416+
reg,
362417
)
363418
nbti = pyg4ometry.geant4.MaterialCompound("nbti", 5.7, 2, reg)
364419
nbti.set_state("solid")
@@ -377,11 +432,21 @@ def Solenoid(innerRadius, thickness, length, constants, reg=None):
377432
zOffset = i * 2 * coilLengthZ
378433
iCoil += 1
379434
pyg4ometry.geant4.PhysicalVolume(
380-
[0, 0, 0], [0, 0, zOffset], coilLV, "coil_" + str(iCoil) + "_pv", solenoidLV, reg
435+
[0, 0, 0],
436+
[0, 0, zOffset],
437+
coilLV,
438+
"coil_" + str(iCoil) + "_pv",
439+
solenoidLV,
440+
reg,
381441
)
382442
iCoil += 1
383443
pyg4ometry.geant4.PhysicalVolume(
384-
[0, 0, 0], [0, 0, -zOffset], coilLV, "coil_" + str(iCoil) + "_pv", solenoidLV, reg
444+
[0, 0, 0],
445+
[0, 0, -zOffset],
446+
coilLV,
447+
"coil_" + str(iCoil) + "_pv",
448+
solenoidLV,
449+
reg,
385450
)
386451

387452
return solenoidLV
@@ -390,7 +455,13 @@ def Solenoid(innerRadius, thickness, length, constants, reg=None):
390455
def ECALBarrel(innerRadius, outerRadius, length, nModulesPhi, nModulesZ, constants, reg):
391456
# container LV
392457
ecalBarrelSolid = pyg4ometry.geant4.solid.Tubs(
393-
"ecal_barrel_solid", innerRadius, outerRadius, length, 0, constants["twopi"], reg
458+
"ecal_barrel_solid",
459+
innerRadius,
460+
outerRadius,
461+
length,
462+
0,
463+
constants["twopi"],
464+
reg,
394465
)
395466
air = pyg4ometry.geant4.MaterialPredefined("G4_AIR")
396467
ecalBarrelLV = pyg4ometry.geant4.LogicalVolume(ecalBarrelSolid, air, "ecal_barrel_lv", reg)
@@ -439,21 +510,37 @@ def ECALBarrel(innerRadius, outerRadius, length, nModulesPhi, nModulesZ, constan
439510
for i in range(nModulesZ):
440511
iModuleName = "ecal_mod_" + str(i)
441512
iModule = pyg4ometry.geant4.solid.Tubs(
442-
iModuleName + "_solid", innerR2, outerR2, 0.95 * dz, startAngle, sweepAngle, reg
513+
iModuleName + "_solid",
514+
innerR2,
515+
outerR2,
516+
0.95 * dz,
517+
startAngle,
518+
sweepAngle,
519+
reg,
443520
)
444521
iModuleLV = pyg4ometry.geant4.LogicalVolume(
445522
iModule, leadTungstate, iModuleName + "_lv", reg
446523
)
447524
pyg4ometry.geant4.PhysicalVolume(
448-
[0, 0, 0], [0, 0, iz + 0.5 * dz], iModuleLV, iModuleName + "_pv", segmentLV, reg
525+
[0, 0, 0],
526+
[0, 0, iz + 0.5 * dz],
527+
iModuleLV,
528+
iModuleName + "_pv",
529+
segmentLV,
530+
reg,
449531
)
450532
iz += dz
451533

452534
# nModulesPhi = 1
453535
for i in range(nModulesPhi):
454536
angle = i * segmentAngle
455537
pyg4ometry.geant4.PhysicalVolume(
456-
[0, 0, angle], [0, 0, 0], segmentLV, "ecal_segment_" + str(i) + "_pv", ecalBarrelLV, reg
538+
[0, 0, angle],
539+
[0, 0, 0],
540+
segmentLV,
541+
"ecal_segment_" + str(i) + "_pv",
542+
ecalBarrelLV,
543+
reg,
457544
)
458545
return ecalBarrelLV
459546

0 commit comments

Comments
 (0)