Skip to content

Commit 49bedeb

Browse files
gHashTaggHashTag
andauthored
ci: fix trusted-bot no-op step shell parse error (Closes #1031) (#1082)
The inline echo contained '#' and unbalanced parens, truncating the command and exiting 2, so the gate concluded failure for bot PRs even though IS_BOT was true and substantive steps skipped. Use a block scalar with plain ASCII echo. Closes #1031 Co-authored-by: gHashTag <admin@t27.ai>
1 parent a15b786 commit 49bedeb

4 files changed

Lines changed: 12 additions & 3 deletions

File tree

.github/workflows/issue-gate.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ jobs:
2121
steps:
2222
- name: Trusted-bot bypass (no-op pass)
2323
if: env.IS_BOT == 'true'
24-
run: echo "Trusted bot PR -- Dependabot or github-actions -- Issue Gate passes as no-op (Closes #1031)."
24+
run: |
25+
echo "Trusted bot PR -- gate passes as no-op. Closes 1031."
2526
2627
- name: Check for linked issues in PR
2728
if: env.IS_BOT != 'true'

.github/workflows/l1-traceability.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ jobs:
1818
steps:
1919
- name: Trusted-bot bypass (no-op pass)
2020
if: env.IS_BOT == 'true'
21-
run: echo "Trusted bot PR -- Dependabot or github-actions -- L1 TRACEABILITY gate passes as no-op (Closes #1031)."
21+
run: |
22+
echo "Trusted bot PR -- gate passes as no-op. Closes 1031."
2223
2324
- name: Checkout repository
2425
if: env.IS_BOT != 'true'

.github/workflows/now-sync-gate.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ jobs:
1818
steps:
1919
- name: Trusted-bot bypass (no-op pass)
2020
if: env.IS_BOT == 'true'
21-
run: echo "Trusted bot PR -- Dependabot or github-actions -- NOW Sync Gate passes as no-op (Closes #1031)."
21+
run: |
22+
echo "Trusted bot PR -- gate passes as no-op. Closes 1031."
2223
2324
- uses: actions/checkout@v4
2425
if: env.IS_BOT != 'true'

docs/NOW.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@
22

33
Last updated: 2026-06-14
44

5+
## ci-fix-bypass-echo -- fix no-op bypass step shell parse error (Closes #1031)
6+
7+
- **WHERE** (CI only): `.github/workflows/l1-traceability.yml`, `.github/workflows/issue-gate.yml`, `.github/workflows/now-sync-gate.yml`. The trusted-bot no-op step used an inline `run: echo "... (Closes #1031)."`; the `#` opened a YAML/shell comment that truncated the command and the unbalanced parenthesis made the shell exit 2, so the gate job concluded `failure` for bots even though IS_BOT was correctly true and all substantive steps skipped. Switched to a block scalar (`run: |`) with a plain ASCII echo (no `#`, no parentheses). No source/specs/codegen/conformance/`gen/` touched.
8+
- **Why**: completes #1081 so trusted-bot PRs report the required gates as `success`. Verified on dep PRs #1043/#1045/#1047/#1048/#1057/#1058. Human PRs remain fully gated. L6/L5 untouched; L4 not applicable (workflow YAML). Closes #1031.
9+
- **Anchor**: phi^2 + phi^-2 = 3
10+
511
## ci-bot-gate-pass-not-skip -- trusted-bot gates PASS as no-op instead of SKIP (Closes #1031)
612

713
- **WHERE** (CI only): `.github/workflows/l1-traceability.yml`, `.github/workflows/issue-gate.yml`, `.github/workflows/now-sync-gate.yml`. Replaces the job-level `if:` bot-skip with a job-level `env.IS_BOT` flag (true when `github.actor` OR `github.event.pull_request.user.login` is `dependabot[bot]`/`github-actions[bot]`). The job now always RUNS; a leading no-op step passes for bots and every substantive step is guarded with `if: env.IS_BOT != 'true'`. No source, specs, codegen, conformance JSON, or `gen/` artefacts touched.

0 commit comments

Comments
 (0)