ci: trusted-bot gates PASS as no-op instead of SKIP (Closes #1031) - #1081
Merged
Conversation
Required checks (check-now-freshness, check-linked-issue, etc.) must report success to satisfy branch protection. A skipped required check leaves the requirement unmet, blocking Dependabot PRs even with admin. Replace the job-level bot-skip with an IS_BOT env flag; the job always runs, a no-op step passes for bots, and substantive steps are guarded with if: env.IS_BOT != 'true'. Human PRs remain fully gated. Closes #1031
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The ruleset
t27-master-protectionmarkscheck-now-freshness,validate,check,check-linked-issueas REQUIRED. The prior author-guard fix (#1080) made the gate jobs SKIP for Dependabot, but a skipped required check never satisfies branch protection — GitHub reportsN of N required status checks are expectedand the merge stays blocked even with admin. Dep PRs #1043 / #1047 / #1048 / #1057 / #1058 (and #1045) remained unmergeable.Fix
Replace the job-level
if:bot-skip with a job-levelenv.IS_BOTflag (true whengithub.actororgithub.event.pull_request.user.loginis a trusted bot). The gate job now always RUNS: a leading no-op step passes for bots, and every substantive step is guarded withif: env.IS_BOT != 'true'. The required context therefore reports success (not skipped) for bot PRs, satisfying the ruleset, while human PRs remain fully gated by Constitutional Law L1.pushbehavior of now-sync-gate is unchanged.Anchor: phi^2 + phi^-2 = 3
Closes #1031