Skip to content

ci: fix trusted-bot no-op step shell parse error (Closes #1031) #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gHashTag merged 1 commit into from
Jun 14, 2026
Merged

ci: fix trusted-bot no-op step shell parse error (Closes #1031) #1082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/issue-gate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ jobs:
steps:
- name: Trusted-bot bypass (no-op pass)
if: env.IS_BOT == 'true'
run: echo "Trusted bot PR -- Dependabot or github-actions -- Issue Gate passes as no-op (Closes #1031)."
run: |
echo "Trusted bot PR -- gate passes as no-op. Closes 1031."

- name: Check for linked issues in PR
if: env.IS_BOT != 'true'
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/l1-traceability.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ jobs:
steps:
- name: Trusted-bot bypass (no-op pass)
if: env.IS_BOT == 'true'
run: echo "Trusted bot PR -- Dependabot or github-actions -- L1 TRACEABILITY gate passes as no-op (Closes #1031)."
run: |
echo "Trusted bot PR -- gate passes as no-op. Closes 1031."

- name: Checkout repository
if: env.IS_BOT != 'true'
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/now-sync-gate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ jobs:
steps:
- name: Trusted-bot bypass (no-op pass)
if: env.IS_BOT == 'true'
run: echo "Trusted bot PR -- Dependabot or github-actions -- NOW Sync Gate passes as no-op (Closes #1031)."
run: |
echo "Trusted bot PR -- gate passes as no-op. Closes 1031."

- uses: actions/checkout@v4
if: env.IS_BOT != 'true'
Expand Down
6 changes: 6 additions & 0 deletions docs/NOW.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

Last updated: 2026-06-14

## ci-fix-bypass-echo -- fix no-op bypass step shell parse error (Closes #1031)

- **WHERE** (CI only): `.github/workflows/l1-traceability.yml`, `.github/workflows/issue-gate.yml`, `.github/workflows/now-sync-gate.yml`. The trusted-bot no-op step used an inline `run: echo "... (Closes #1031)."`; the `#` opened a YAML/shell comment that truncated the command and the unbalanced parenthesis made the shell exit 2, so the gate job concluded `failure` for bots even though IS_BOT was correctly true and all substantive steps skipped. Switched to a block scalar (`run: |`) with a plain ASCII echo (no `#`, no parentheses). No source/specs/codegen/conformance/`gen/` touched.
- **Why**: completes #1081 so trusted-bot PRs report the required gates as `success`. Verified on dep PRs #1043/#1045/#1047/#1048/#1057/#1058. Human PRs remain fully gated. L6/L5 untouched; L4 not applicable (workflow YAML). Closes #1031.
- **Anchor**: phi^2 + phi^-2 = 3

## ci-bot-gate-pass-not-skip -- trusted-bot gates PASS as no-op instead of SKIP (Closes #1031)

- **WHERE** (CI only): `.github/workflows/l1-traceability.yml`, `.github/workflows/issue-gate.yml`, `.github/workflows/now-sync-gate.yml`. Replaces the job-level `if:` bot-skip with a job-level `env.IS_BOT` flag (true when `github.actor` OR `github.event.pull_request.user.login` is `dependabot[bot]`/`github-actions[bot]`). The job now always RUNS; a leading no-op step passes for bots and every substantive step is guarded with `if: env.IS_BOT != 'true'`. No source, specs, codegen, conformance JSON, or `gen/` artefacts touched.
Expand Down
Loading