verify.sh: add [5/5] reseal-prev advisory sub-check (seal-state vs PR diff). Closes #1136#1139
Merged
Merged
Conversation
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
PR DashboardGenerated at: 2026-06-14 17:50:05 UTC
Summary
Seal Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extend the advisory
scripts/verify.shumbrella (#1124 / #1127, then #1134) with a 5thsub-check,
[5/5] reseal-prev, that ties the NMSE seal state to the CURRENT PR DIFF, andupdate the
make helptext. Advisory only -- always exits 0, never reseals, never blocks.Motivation
Sub-check
[1/5]already reports the ABSOLUTE seal state (fresh / stale / unsealed), but onits own that is noisy: the seal is frequently stale on master for reasons unrelated to a
given PR, so a contributor cannot tell whether THEIR change needs a reseal. The only question
that actually matters before a push is: "does this PR touch the sealed compiler, and if so,
is the seal current?"
[5/5]answers exactly that by combining[1/5]'s seal verdict with a diff of the PR:bootstrap/src/compiler.rs-> seal state is irrelevant to this PR; anypre-existing staleness is unrelated. Reports
OK.compiler.rsAND the seal is fresh ->OK.compiler.rsAND the seal is stale/unsealed -> prints aREMINDER: IF theedit changed numerics, reseal explicitly (
make seal); IF it did not (anallow(), acomment, a test), the existing seal state is fine. It is explicitly a reminder, NOT a
verdict on whether the edit is numeric -- the script never inspects semantics.
Guarantees (consistent with #1127 / #1134)
remain the real gate.
[1/5]'s seal exit code and diffs the local base ref(
origin/master, falling back tomaster); only as fresh as the lastgit fetch.VERIFY_SKIP_RESEAL=1disables just this sub-check; the other skip flags(
VERIFY_SKIP_TEST,VERIFY_SKIP_GATES) are unchanged.Files
scripts/verify.sh: add[5/5] reseal-prev, renumber[1/4..4/4]->[1/5..4/5], refreshthe header sub-check list and usage block.
Makefile: updatemake helpto mention reseal-preview and theVERIFY_SKIP_RESEALflag.Verification
bash -n scripts/verify.shclean;make verifyruns all 5 sub-checks and exits 0.[5/5]reportsOK(compiler.rs not in diff).compiler.rsedit and a stale seal,[5/5]prints theREMINDERandstill exits 0.
VERIFY_SKIP_RESEAL=1correctly skips[5/5].L6 gf16 SSOT untouched; catalog stays 83; no gen/ edits; ASCII-only added lines; no quality
claim added.