fix(ci): widen NOW freshness gate to accept east-of-UTC local dates#1235
Merged
Conversation
The check-now-freshness job validated docs/NOW.md 'Last updated' against the UTC window [YESTERDAY_UTC .. TODAY_UTC], producing a systematic false-negative for east-of-UTC contributors (maintainer is UTC+07): a local 'today' date is rejected as 'too old' while UTC is still on the previous day. Observed on PR #1231 (NOW.md=2026-07-01, UTC=2026-06-30), which blocked the stacked conformance-promote chain #1231 -> #1233. Widen the window to [YESTERDAY_UTC .. TOMORROW_UTC]: tomorrow is accepted so any east-of-UTC local 'today' passes; older-than-yesterday still fails (stale-NOW protection); newer-than-tomorrow still fails (typo protection); a missing 'Last updated:' line now fails with a clear message. ISO-8601 zero-padded dates compare correctly as strings. CI/workflow-only; catalog stays 83; no spec or conformance vector touched. Closes #1234
Contributor
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This was referenced Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The required NOW Sync Gate job
check-now-freshnessvalidated thedocs/NOW.mdLast updateddate against the UTC window[YESTERDAY_UTC .. TODAY_UTC]. For an east-of-UTC contributor (maintainer is UTC+07) who stamps NOW.md with their LOCAL calendar date, this is a systematic false-negative: the local "today" is rejected as "too old" while UTC is still on the previous day.Observed on PR #1231 (NOW.md=
2026-07-01, UTC=2026-06-30->NOW.md date (2026-07-01) is too old), which currently BLOCKS the stacked conformance-promote chain #1231 -> #1233.Change
Widen the accepted window to
[YESTERDAY_UTC .. TOMORROW_UTC]:TOMORROW_UTCaccepted -> any east-of-UTC local "today" passes.YESTERDAY_UTCstill FAILS (stale-NOW protection preserved).TOMORROW_UTCstill FAILS (typo-far-in-future protection).Last updated:line now fails with a clear message.ISO-8601 zero-padded dates compare correctly as strings -> no date parsing added. CI/workflow-only change; catalog stays 83; no spec, no conformance vector, no count touched.
Verification
Logic self-tested locally on boundary dates: yesterday/today/tomorrow UTC PASS; older FAIL(too-old); far-future FAIL(future); missing line FAIL(no-date). YAML lints clean;
date -u -d tomorrowsupported on ubuntu-latest.Closes #1234