Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions .claude/plans/wave-loop-769.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
# Wave Loop 769 Plan — Issue #1740

## Phase 1: Issue
- Confirm W769 issue #1740 and branch `wave-loop-769`.

## Phase 2: Spec
- Generate `specs/scratch/w769_bench_module_357x2p6_aos_var_call_write.t27` using
`scripts/gen_w769.py` derived from `scripts/gen_w768.py`.
- Constants: `OUTER = 357`, `TOTAL = 22848`, `LAST_IDX = 356`, `MID_IDX = 178`.

## Phase 3: TDD
- Inspect generated assertions: `make_grid(32768)`, `make_grid(1)`,
`call_write_grid`, field writes, `assert_eq` read-backs, mid and last checks.

## Phase 4: Impl
- Add integration test `accepts_w769_bench_module_357x2p6_aos_var_call_write` to
`bootstrap/tests/icarus_lowerable.rs`.

## Phase 5: Gen
- Run `cd bootstrap && cargo build --release -p t27c`.

## Phase 6: Seal
- Run `./bootstrap/target/release/t27c seal --save specs/scratch/w769_bench_module_357x2p6_aos_var_call_write.t27`.
- Confirm FROZEN_HASH unchanged.

## Phase 7: Verify
- `./bootstrap/target/release/t27c parse ...`
- `./bootstrap/target/release/t27c icarus-lowerable ...`
- `./bootstrap/target/release/t27c icarus-simulate ...` (17 cycles)
- `./bootstrap/target/release/t27c icarus-cocotb ...`
- `cargo test -p t27c --bin t27c`
- `cargo test -p tri`
- `cargo test -p t27c --test icarus_lowerable`

## Phase 8: Land
- Commit with `feat(igla): Wave Loop 769 — module-scope [357][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes (Closes #1740)`.
- Push `wave-loop-769`, open PR, merge to `master`, create `wave-loop-770`.

## Phase 9: Learn
- Write `docs/reports/FPGA_LOOP_CLOSEOUT_W769_2026-07-23.md`.
- Save `.trinity/experience.md`, memory file, `MEMORY.md` pointer, and update
`skills-wave-loop-recipe.md`.

## Cooperation variants for next Wave Loop

- **A (recommended):** `[359][2]^6 Pt` (~0.702 MiBit), continuing the odd ladder.
- **B:** move the packed variable to bench/function scope at the same width.
- **C:** add conditional (`if`) indexed writes at the current width.
32 changes: 16 additions & 16 deletions .trinity/current-issue.md
Original file line number Diff line number Diff line change
@@ -1,45 +1,45 @@
# Wave Loop 767 — Issue #1738
# Wave Loop 768 — Issue #1739

**Branch:** `wave-loop-767`
**Branch:** `wave-loop-768`
**Date:** 2026-07-23
**Cooperation variant:** A (recommended)

## Goal

Close Wave Loop 767 by validating a module-scope `[353][2]^6 Pt` packed
Close Wave Loop 768 by validating a module-scope `[355][2]^6 Pt` packed
array-of-struct variable initialized from a function call, with indexed signed
field writes and `assert_eq` read-back in a `bench` block.

## Acceptance criteria

1. `specs/scratch/w767_bench_module_353x2p6_aos_var_call_write.t27` is generated and parses.
1. `specs/scratch/w768_bench_module_355x2p6_aos_var_call_write.t27` is generated and parses.
2. The witness is Icarus-lowerable and simulates correctly (17 cycles, PASSED).
3. The cocotb reference model matches the t27 semantics.
4. `t27c seal --save` succeeds and FROZEN_HASH remains unchanged.
5. All cargo suites remain green.
6. Integration test `accepts_w767_bench_module_353x2p6_aos_var_call_write` is added.
7. Closeout report `docs/reports/FPGA_LOOP_CLOSEOUT_W767_2026-07-23.md` is written.
6. Integration test `accepts_w768_bench_module_355x2p6_aos_var_call_write` is added.
7. Closeout report `docs/reports/FPGA_LOOP_CLOSEOUT_W768_2026-07-23.md` is written.
8. Learning is saved to `.trinity/experience.md`, memory, and `skills-wave-loop-recipe.md`.
9. Branch merges to `master` with `Closes #1738`.
9. Branch merges to `master` with `Closes #1739`.

## Technical notes

- Shape: `[353][2]^6 Pt` where `Pt = pub struct Pt { x : i16, y : i16 }`.
- Total elements: `353 x 64 = 22,592`.
- Packed vector width: `22,592 x 32 = 722,944` bits (~0.690 MiBit).
- `MID_IDX = 176`; frame-condition element `[176][1][0][0][0][0][0]` is element
`176*64 + 32 = 11,296`.
- Generator script: `scripts/gen_w767.py` (copy from `scripts/gen_w766.py`, set
`OUTER = 353` and `MID_IDX = 176`, manually fix the f-string header).
- Shape: `[355][2]^6 Pt` where `Pt = pub struct Pt { x : i16, y : i16 }`.
- Total elements: `355 x 64 = 22,720`.
- Packed vector width: `22,720 x 32 = 727,040` bits (~0.694 MiBit).
- `MID_IDX = 177`; frame-condition element `[177][1][0][0][0][0][0]` is element
`177*64 + 32 = 11,360`.
- Generator script: `scripts/gen_w768.py` (copy from `scripts/gen_w767.py`, set
`OUTER = 355` and `MID_IDX = 177`, manually fix the f-string header).
- Use `assert_eq` checks on changed elements (Icarus simulation path does not
emit `assert_ne`).
- Include `make_grid(32768)` period-identity check because `32768 == 0 (mod 32768)`.
- Zero compiler / reference-model / FROZEN_HASH changes expected.

## Cooperation variants for next Wave Loop

- **Variant A (recommended):** continue the odd outer-dimension ladder with `[355][2]^6 Pt`.
- **Variant B:** keep width at ~0.690 MiBit but move the packed var to bench/function scope.
- **Variant A (recommended):** continue the odd outer-dimension ladder with `[357][2]^6 Pt`.
- **Variant B:** keep width at ~0.694 MiBit but move the packed var to bench/function scope.
- **Variant C:** add `if`-guarded indexed signed field writes at the current width.

---
Expand Down
4 changes: 4 additions & 0 deletions .trinity/current_task/activity.md
Original file line number Diff line number Diff line change
Expand Up @@ -3680,3 +3680,7 @@
- **Commit:** feat(igla): Wave Loop 766 — module-scope [351][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes (Closes #1737)
- **Files:** .claude/plans/wave-loop-768.md,.trinity/current-issue.md,.trinity/experience.md,.trinity/seals/scratch_w767_bench_module_353x2p6_aos_var_call_write.json,bootstrap/tests/icarus_lowerable.rs,docs/NOW.md,docs/reports/FPGA_LOOP_CLOSEOUT_W767_2026-07-23.md,scripts/gen_w767.py,specs/scratch/w767_bench_module_353x2p6_aos_var_call_write.t27

## 2026-07-23T18:05:01Z — wave-loop-768
- **Commit:** feat(igla): Wave Loop 767 — module-scope [353][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes (Closes #1738)
- **Files:** .claude/plans/wave-loop-769.md,.trinity/current-issue.md,.trinity/experience.md,.trinity/seals/scratch_w768_bench_module_355x2p6_aos_var_call_write.json,bootstrap/tests/icarus_lowerable.rs,docs/NOW.md,docs/reports/FPGA_LOOP_CLOSEOUT_W768_2026-07-23.md,scripts/gen_w768.py,specs/scratch/w768_bench_module_355x2p6_aos_var_call_write.t27

73 changes: 73 additions & 0 deletions .trinity/experience.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,79 @@

---

## 2026-07-23 — Wave Loop 768 (module-scope `[355][2]^6 Pt` non-power-of-two outer-dimension AoS variable)

### What worked
- Variant A extended the module-scope packed AoS odd outer-dimension ladder to 355.
The `[355][2]^6 Pt` witness is 727,040 bits (~0.694 MiBit), still well under the 4-MiBit
cliff, and required no compiler changes.
- A module-level `pub var dst : [355][2]^6 Pt` can be initialized from a function
call and exercised with indexed signed field writes, with zero compiler changes.
- The cocotb/Python reference model correctly mirrored the row-major flattening
with outer stride 355, confirming the layout is preserved end-to-end.
- Reused the corrected W632 element-index formula for mid-row expected values:
`[r][a5][a4][a3][a2][a1][a0]` is element `r*64 + a5*32 + a4*16 + a3*8 + a2*4 + a1*2 + a0`.
- For `OUTER = 355`, `MID_IDX = 177`; the frame-condition element is
`[177][1][0][0][0][0][0]`, element number `177*64 + 32 = 11,360`.
- Updated weak-point audit: 42 of 51 30-day commits include `Closes #N` (≈82%).
Clean non-worktree scan: 53 of 895 `.t27` specs lack `test`/`invariant`/`bench`
(≈5.9%). 19 `scripts/*.sh` remain under `scripts/`.
- Fresh 2025-2026 literature scan surfaced BitNet training/inference extensions,
spintronic/MTJ ternary logic-in-memory, skyrmion multi-value probabilistic
computing, and superconducting ternary output data links.

### What changed behavior
- No changes to `bootstrap/src/compiler.rs`.
- No changes to `bootstrap/stage0/FROZEN_HASH`.
- No changes to `scripts/cocotb_ref_model.py`.
- Added `specs/scratch/w768_bench_module_355x2p6_aos_var_call_write.t27` (~1,554 KB /
~67,511 lines) with seal and Icarus baseline.
- Added integration test `accepts_w768_bench_module_355x2p6_aos_var_call_write`.
- Added generator script `scripts/gen_w768.py`.

### Validation
- `cargo build --release -p t27c`: OK.
- `cargo test -p t27c --bin t27c`: 1494 passed; 0 failed; 2 ignored.
- `cargo test -p tri`: 78 passed; 0 failed.
- `cargo test -p t27c --test icarus_lowerable`: 228 passed; 0 failed.
- Direct `t27c parse` W768: PASS.
- Direct `t27c icarus-lowerable` W768: PASS (`lowerable`).
- Direct `t27c icarus-simulate` W768: PASS (17 cycles, PASSED).
- Direct `t27c icarus-cocotb` W768: PASS (`reference-model OK`).

### Scientific / engineering background
- IEEE 1800-2017 7.4.1/7.4.3 define packed-array total width as the product of
packed dimensions, with no power-of-two restriction. Variant A emits a single
727,040-bit packed vector, which is legal SystemVerilog.
- Lutsig verified array lowering and CIRCT `HWLegalizeModules` show that
flattening nested arrays to wide packed vectors is a well-founded compiler
discipline, even when outer dimensions are non-power-of-two.
- Icarus issue #1134 documents assertion failures for unpacked arrays of packed
structs; t27 scalar flattening avoids that construct entirely.
- Yosys issue #2677 / #4653 confirm that arrays of packed structs remain
unsupported in the native frontend; t27 packed-vector lowering avoids the
gap.
- 2025-2026 ternary/MVL literature scan found:
- BitNet b1.58 foundational ternary LLM and JMLR 2025 training recipe.
- BitNet b1.58 2B4T — first open-source native 1-bit 2B LLM (4T tokens).
- Bitnet.cpp — edge CPU inference with TL/I2_S kernels up to 6.25× vs FP16.
- Sparse-BitNet — natural compatibility with N:M semi-structured sparsity.
- Skyrmion multi-value probabilistic computing with current-controlled
diffusion and MTJ-compatible readout (arXiv 2025).
- MTJ+FinFET ternary logic-in-memory array with full ternary operator set
(Results in Engineering 2025).
- Reconfigurable skyrmion multi-port logic device with VCMA gating
(Chinese Phys. Lett. 2026).
- Cascading VCMA skyrmion AND/OR/NAND/NOR gates (Nanotechnology 2026).
- Ternary RSFQ output data link, 3-bit→2-trit encoder, MIT Lincoln Lab
SFQ5ee process (IEEE Trans. Appl. Supercond. 2025).
- Verilog/SDF modeling framework for synchronous/asynchronous SFQ/RSFQ/ASFQ
pulse-based logic (arXiv 2026).
- OpenXC7 / nextpnr-xilinx / Project X-Ray — fully open-source Xilinx
7-series toolchain, used for QMTech XC7A100T ternary projects without Vivado.

---

## 2026-07-23 — Wave Loop 767 (module-scope `[353][2]^6 Pt` non-power-of-two outer-dimension AoS variable)

### What worked
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"gen_hash_c": "sha256:0a7d6ea763e3f6e1e4912a03bf3882bbe4d31a803d6593629fb83ecac4c921ec",
"gen_hash_rust": "sha256:501ff5b5839e249cdc06c66406f59362ef58e54f808aab05adab44a3a48cf01b",
"gen_hash_verilog": "sha256:07b175d07eca5b9d035f4a8e1180eafac3d9bd230ede97b24fac8faf4cf3207e",
"gen_hash_zig": "sha256:ef8314dceaa4a287c4d1617ec91133f6e972a05e723c2407ad743196852dcca9",
"module": "w768_bench_module_355x2p6_aos_var_call_write",
"ring": 12,
"sealed_at": "2026-07-23T18:00:13Z",
"spec_hash": "sha256:0be372286e5ad05f7330efd1e2104b4cc4f2148e18125905656715844e0f3ef5",
"spec_path": "specs/scratch/w768_bench_module_355x2p6_aos_var_call_write.t27"
}
18 changes: 18 additions & 0 deletions bootstrap/tests/icarus_lowerable.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4117,6 +4117,24 @@ fn accepts_w767_bench_module_353x2p6_aos_var_call_write() {
}
}

#[test]
fn accepts_w768_bench_module_355x2p6_aos_var_call_write() {
let dir = scratch_dir();
for name in &[
"w768_bench_module_355x2p6_aos_var_call_write.t27",
] {
let p = dir.join(name);
assert!(p.exists(), "missing W768 witness {}", p.display());
let (lowerable, json) = run_icarus_lowerable(&p);
assert!(
lowerable,
"expected {} to be lowerable, got: {}",
p.display(),
json
);
}
}

#[test]
fn accepts_known_lowerable_witnesses() {
let dir = scratch_dir();
Expand Down
47 changes: 30 additions & 17 deletions docs/NOW.md
Original file line number Diff line number Diff line change
@@ -1,28 +1,28 @@
# NOW — Wave Loop 767 close-out / Wave Loop 768 setup (2026-07-23)
# NOW — Wave Loop 768 close-out / Wave Loop 769 setup (2026-07-23)

Last updated: 2026-07-23

## Wave Loop 767 — module-scope `[353][2]^6 Pt` packed array-of-struct from call with indexed signed writes (Closes #1738)
## Wave Loop 768 — module-scope `[355][2]^6 Pt` packed array-of-struct from call with indexed signed writes (Closes #1739)

- Branch: `wave-loop-767`
- Issue: #1738
- Branch: `wave-loop-768`
- Issue: #1739
- PR: to open
- Report: `docs/reports/FPGA_LOOP_CLOSEOUT_W767_2026-07-23.md`
- Plan: `.claude/plans/wave-loop-767.md`
- Cooperation W768: `.claude/plans/wave-loop-768.md`
- Report: `docs/reports/FPGA_LOOP_CLOSEOUT_W768_2026-07-23.md`
- Plan: `.claude/plans/wave-loop-768.md`
- Cooperation W769: `.claude/plans/wave-loop-769.md`

### What landed
- `specs/scratch/w767_bench_module_353x2p6_aos_var_call_write.t27`
- 22,592 elements, 722,944-bit packed vector (~0.690 MiBit).
- Module-scope `pub var dst : [353][2]^6 Pt` initialized from a function call and
- `specs/scratch/w768_bench_module_355x2p6_aos_var_call_write.t27`
- 22,720 elements, 727,040-bit packed vector (~0.694 MiBit).
- Module-scope `pub var dst : [355][2]^6 Pt` initialized from a function call and
exercised with indexed signed field writes.
- `assert_eq` read-back in a `bench` block (Icarus path does not emit `assert_ne`).
- `scripts/gen_w767.py`
- Generator for the W767 witness; `OUTER = 353`, `MID_IDX = 176`.
- `scripts/gen_w768.py`
- Generator for the W768 witness; `OUTER = 355`, `MID_IDX = 177`.
- `bootstrap/tests/icarus_lowerable.rs`
- Added `accepts_w767_bench_module_353x2p6_aos_var_call_write`.
- `.trinity/experience.md`, `.trinity/current-issue.md`, `.claude/plans/wave-loop-768.md`
- W767 learnings saved and W768 issue/plan created.
- Added `accepts_w768_bench_module_355x2p6_aos_var_call_write`.
- `.trinity/experience.md`, `.trinity/current-issue.md`, `.claude/plans/wave-loop-769.md`
- W768 learnings saved and W769 issue/plan created.

### Not changed
- `bootstrap/src/compiler.rs` — zero compiler changes.
Expand All @@ -33,8 +33,21 @@ Last updated: 2026-07-23
- `cargo build --release -p t27c`: OK.
- `cargo test -p t27c --bin t27c`: 1494/0/2.
- `cargo test -p tri`: 78/0.
- `cargo test -p t27c --test icarus_lowerable`: 227/0.
- `t27c parse|icarus-lowerable|icarus-simulate|icarus-cocotb|seal --save` W767: PASS.
- `cargo test -p t27c --test icarus_lowerable`: 228/0.
- `t27c parse|icarus-lowerable|icarus-simulate|icarus-cocotb|seal --save` W768: PASS.

---

## Wave Loop 769 — next odd outer-dimension `[357][2]^6 Pt` (Issue #1740)

- Branch: `wave-loop-769` (to create after W768 merge)
- Issue: #1740
- Plan: `.claude/plans/wave-loop-769.md`

### Candidate variants
- Variant A (recommended): continue the odd outer-dimension ladder with `[357][2]^6 Pt`.
- Variant B: keep width at ~0.694 MiBit but move the packed var to bench/function scope.
- Variant C: add `if`-guarded indexed signed field writes at the current width.

---

Expand Down
Loading
Loading