Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions .claude/plans/wave-loop-770.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
# Wave Loop 770 Plan — Issue #1741

## Phase 1: Issue
- Confirm W770 issue #1741 and branch `wave-loop-770`.

## Phase 2: Spec
- Generate `specs/scratch/w770_bench_module_359x2p6_aos_var_call_write.t27` using
`scripts/gen_w770.py` derived from `scripts/gen_w769.py`.
- Constants: `OUTER = 359`, `TOTAL = 22976`, `LAST_IDX = 358`, `MID_IDX = 179`.

## Phase 3: TDD
- Inspect generated assertions: `make_grid(32768)`, `make_grid(1)`,
`call_write_grid`, field writes, `assert_eq` read-backs, mid and last checks.

## Phase 4: Impl
- Add integration test `accepts_w770_bench_module_359x2p6_aos_var_call_write` to
`bootstrap/tests/icarus_lowerable.rs`.

## Phase 5: Gen
- Run `cd bootstrap && cargo build --release -p t27c`.

## Phase 6: Seal
- Run `./bootstrap/target/release/t27c seal --save specs/scratch/w770_bench_module_359x2p6_aos_var_call_write.t27`.
- Confirm FROZEN_HASH unchanged.

## Phase 7: Verify
- `./bootstrap/target/release/t27c parse ...`
- `./bootstrap/target/release/t27c icarus-lowerable ...`
- `./bootstrap/target/release/t27c icarus-simulate ...` (17 cycles)
- `./bootstrap/target/release/t27c icarus-cocotb ...`
- `cargo test -p t27c --bin t27c`
- `cargo test -p tri`
- `cargo test -p t27c --test icarus_lowerable`

## Phase 8: Land
- Commit with `feat(igla): Wave Loop 770 — module-scope [359][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes (Closes #1741)`.
- Push `wave-loop-770`, open PR, merge to `master`, create `wave-loop-771`.

## Phase 9: Learn
- Write `docs/reports/FPGA_LOOP_CLOSEOUT_W770_2026-07-24.md`.
- Save `.trinity/experience.md`, memory file, `MEMORY.md` pointer, and update
`skills-wave-loop-recipe.md`.

## Cooperation variants for next Wave Loop

- **A (recommended):** `[361][2]^6 Pt` (~0.705 MiBit), continuing the odd ladder.
- **B:** move the packed variable to bench/function scope at the same width.
- **C:** add conditional (`if`) indexed writes at the current width.
34 changes: 17 additions & 17 deletions .trinity/current-issue.md
Original file line number Diff line number Diff line change
@@ -1,45 +1,45 @@
# Wave Loop 768 — Issue #1739
# Wave Loop 769 — Issue #1740

**Branch:** `wave-loop-768`
**Date:** 2026-07-23
**Branch:** `wave-loop-769`
**Date:** 2026-07-24
**Cooperation variant:** A (recommended)

## Goal

Close Wave Loop 768 by validating a module-scope `[355][2]^6 Pt` packed
Close Wave Loop 769 by validating a module-scope `[357][2]^6 Pt` packed
array-of-struct variable initialized from a function call, with indexed signed
field writes and `assert_eq` read-back in a `bench` block.

## Acceptance criteria

1. `specs/scratch/w768_bench_module_355x2p6_aos_var_call_write.t27` is generated and parses.
1. `specs/scratch/w769_bench_module_357x2p6_aos_var_call_write.t27` is generated and parses.
2. The witness is Icarus-lowerable and simulates correctly (17 cycles, PASSED).
3. The cocotb reference model matches the t27 semantics.
4. `t27c seal --save` succeeds and FROZEN_HASH remains unchanged.
5. All cargo suites remain green.
6. Integration test `accepts_w768_bench_module_355x2p6_aos_var_call_write` is added.
7. Closeout report `docs/reports/FPGA_LOOP_CLOSEOUT_W768_2026-07-23.md` is written.
6. Integration test `accepts_w769_bench_module_357x2p6_aos_var_call_write` is added.
7. Closeout report `docs/reports/FPGA_LOOP_CLOSEOUT_W769_2026-07-24.md` is written.
8. Learning is saved to `.trinity/experience.md`, memory, and `skills-wave-loop-recipe.md`.
9. Branch merges to `master` with `Closes #1739`.
9. Branch merges to `master` with `Closes #1740`.

## Technical notes

- Shape: `[355][2]^6 Pt` where `Pt = pub struct Pt { x : i16, y : i16 }`.
- Total elements: `355 x 64 = 22,720`.
- Packed vector width: `22,720 x 32 = 727,040` bits (~0.694 MiBit).
- `MID_IDX = 177`; frame-condition element `[177][1][0][0][0][0][0]` is element
`177*64 + 32 = 11,360`.
- Generator script: `scripts/gen_w768.py` (copy from `scripts/gen_w767.py`, set
`OUTER = 355` and `MID_IDX = 177`, manually fix the f-string header).
- Shape: `[357][2]^6 Pt` where `Pt = pub struct Pt { x : i16, y : i16 }`.
- Total elements: `357 x 64 = 22,848`.
- Packed vector width: `22,848 x 32 = 731,136` bits (~0.697 MiBit).
- `MID_IDX = 178`; frame-condition element `[178][1][0][0][0][0][0]` is element
`178*64 + 32 = 11,424`.
- Generator script: `scripts/gen_w769.py` (copy from `scripts/gen_w768.py`, set
`OUTER = 357` and `MID_IDX = 178`, manually fix the f-string header).
- Use `assert_eq` checks on changed elements (Icarus simulation path does not
emit `assert_ne`).
- Include `make_grid(32768)` period-identity check because `32768 == 0 (mod 32768)`.
- Zero compiler / reference-model / FROZEN_HASH changes expected.

## Cooperation variants for next Wave Loop

- **Variant A (recommended):** continue the odd outer-dimension ladder with `[357][2]^6 Pt`.
- **Variant B:** keep width at ~0.694 MiBit but move the packed var to bench/function scope.
- **Variant A (recommended):** continue the odd outer-dimension ladder with `[359][2]^6 Pt`.
- **Variant B:** keep width at ~0.697 MiBit but move the packed var to bench/function scope.
- **Variant C:** add `if`-guarded indexed signed field writes at the current width.

---
Expand Down
4 changes: 4 additions & 0 deletions .trinity/current_task/activity.md
Original file line number Diff line number Diff line change
Expand Up @@ -3684,3 +3684,7 @@
- **Commit:** feat(igla): Wave Loop 767 — module-scope [353][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes (Closes #1738)
- **Files:** .claude/plans/wave-loop-769.md,.trinity/current-issue.md,.trinity/experience.md,.trinity/seals/scratch_w768_bench_module_355x2p6_aos_var_call_write.json,bootstrap/tests/icarus_lowerable.rs,docs/NOW.md,docs/reports/FPGA_LOOP_CLOSEOUT_W768_2026-07-23.md,scripts/gen_w768.py,specs/scratch/w768_bench_module_355x2p6_aos_var_call_write.t27

## 2026-07-23T18:14:36Z — wave-loop-769
- **Commit:** feat(igla): Wave Loop 768 — module-scope [355][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes (Closes #1739)
- **Files:** .claude/plans/wave-loop-770.md,.trinity/current-issue.md,.trinity/experience.md,.trinity/seals/scratch_w769_bench_module_357x2p6_aos_var_call_write.json,bootstrap/tests/icarus_lowerable.rs,docs/NOW.md,docs/reports/FPGA_LOOP_CLOSEOUT_W769_2026-07-24.md,scripts/gen_w769.py,specs/scratch/w769_bench_module_357x2p6_aos_var_call_write.t27

68 changes: 68 additions & 0 deletions .trinity/experience.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,71 @@
## 2026-07-23 — Wave Loop 769 (module-scope `[357][2]^6 Pt` non-power-of-two outer-dimension AoS variable)

### What worked
- Variant A extended the module-scope packed AoS odd outer-dimension ladder to 357.
The `[357][2]^6 Pt` witness is 731,136 bits (~0.697 MiBit), still well under the 4-MiBit
cliff, and required no compiler changes.
- A module-level `pub var dst : [357][2]^6 Pt` can be initialized from a function
call and exercised with indexed signed field writes, with zero compiler changes.
- The cocotb/Python reference model correctly mirrored the row-major flattening
with outer stride 357, confirming the layout is preserved end-to-end.
- Reused the corrected W632 element-index formula for mid-row expected values:
`[r][a5][a4][a3][a2][a1][a0]` is element `r*64 + a5*32 + a4*16 + a3*8 + a2*4 + a1*2 + a0`.
- For `OUTER = 357`, `MID_IDX = 178`; the frame-condition element is
`[178][1][0][0][0][0][0]`, element number `178*64 + 32 = 11,424`.
- Updated weak-point audit: 43 of 52 30-day commits include `Closes #N` (≈83%).
Clean non-worktree scan: 53 of 896 `.t27` specs lack `test`/`invariant`/`bench`
(≈5.9%). 19 `scripts/*.sh` remain under `scripts/`.
- Fresh 2025-2026 literature scan surfaced photonic ternary logic, ternary RISC-V
extensions, in-memory ternary MAC arrays, ternary approximate computing, and
superconducting ternary arithmetic units.

### What changed behavior
- No changes to `bootstrap/src/compiler.rs`.
- No changes to `bootstrap/stage0/FROZEN_HASH`.
- No changes to `scripts/cocotb_ref_model.py`.
- Added `specs/scratch/w769_bench_module_357x2p6_aos_var_call_write.t27` (~1,563 KB /
~67,891 lines) with seal and Icarus baseline.
- Added integration test `accepts_w769_bench_module_357x2p6_aos_var_call_write`.
- Added generator script `scripts/gen_w769.py`.

### Validation
- `cargo build --release -p t27c`: OK.
- `cargo test -p t27c --bin t27c`: 1494 passed; 0 failed; 2 ignored.
- `cargo test -p tri`: 78 passed; 0 failed.
- `cargo test -p t27c --test icarus_lowerable`: 229 passed; 0 failed.
- Direct `t27c parse` W769: PASS.
- Direct `t27c icarus-lowerable` W769: PASS (`lowerable`).
- Direct `t27c icarus-simulate` W769: PASS (17 cycles, PASSED).
- Direct `t27c icarus-cocotb` W769: PASS (`reference-model OK`).

### Scientific / engineering background
- IEEE 1800-2017 7.4.1/7.4.3 define packed-array total width as the product of
packed dimensions, with no power-of-two restriction. Variant A emits a single
731,136-bit packed vector, which is legal SystemVerilog.
- Lutsig verified array lowering and CIRCT `HWLegalizeModules` show that
flattening nested arrays to wide packed vectors is a well-founded compiler
discipline, even when outer dimensions are non-power-of-two.
- Icarus issue #1134 documents assertion failures for unpacked arrays of packed
structs; t27 scalar flattening avoids that construct entirely.
- Yosys issue #2677 / #4653 confirm that arrays of packed structs remain
unsupported in the native frontend; t27 packed-vector lowering avoids the
gap.
- 2025-2026 ternary/MVL literature scan found:
- Photonic ternary logic gates using Mach-Zehnder interferometers for
high-speed multi-value data processing (IEEE PTCL 2026).
- Ternary RISC-V ISA extension proposals for 1.58-bit LLM inference
acceleration (arXiv 2026).
- In-memory ternary multiply-accumulate arrays based on FeFET and RRAM
crossbars (IEEE TED 2026).
- Ternary approximate computing with quality-configurable stochastic
computing kernels (IEEE TC 2026).
- Superconducting ternary full adder and multiplier units in RSFQ/ERSFQ
logic families (IEEE Trans. Appl. Supercond. 2025).
- OpenXC7 / nextpnr-xilinx / Project X-Ray — fully open-source Xilinx
7-series toolchain, used for QMTech XC7A100T ternary projects without Vivado.

---

## 2026-07-23 — Wave Loop 765 (module-scope `[349][2]^6 Pt` non-power-of-two outer-dimension AoS variable)

### What worked
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"gen_hash_c": "sha256:5bd2423fd621a0eb709cce81e7a5b3d6c84b71cc13e51947f817679360273037",
"gen_hash_rust": "sha256:77386df2e1f2367cdb5b5ee918d3183329932dcd8ac2cea3d562da0f3993056f",
"gen_hash_verilog": "sha256:917f0933c9d7f7ba50b2683b905f6b78c8e5fed979a4f8b5b909d8495aaef3bf",
"gen_hash_zig": "sha256:50fc42f1443e9a183df011c1d04caa5d7f664ba4f2f66f1c73d4bbff74c8c384",
"module": "w769_bench_module_357x2p6_aos_var_call_write",
"ring": 12,
"sealed_at": "2026-07-23T18:11:06Z",
"spec_hash": "sha256:1cc03a87173185961f8f7cd46a724c87757d235f73776a8e1586412589419cc6",
"spec_path": "specs/scratch/w769_bench_module_357x2p6_aos_var_call_write.t27"
}
18 changes: 18 additions & 0 deletions bootstrap/tests/icarus_lowerable.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4135,6 +4135,24 @@ fn accepts_w768_bench_module_355x2p6_aos_var_call_write() {
}
}

#[test]
fn accepts_w769_bench_module_357x2p6_aos_var_call_write() {
let dir = scratch_dir();
for name in &[
"w769_bench_module_357x2p6_aos_var_call_write.t27",
] {
let p = dir.join(name);
assert!(p.exists(), "missing W769 witness {}", p.display());
let (lowerable, json) = run_icarus_lowerable(&p);
assert!(
lowerable,
"expected {} to be lowerable, got: {}",
p.display(),
json
);
}
}

#[test]
fn accepts_known_lowerable_witnesses() {
let dir = scratch_dir();
Expand Down
48 changes: 24 additions & 24 deletions docs/NOW.md
Original file line number Diff line number Diff line change
@@ -1,28 +1,28 @@
# NOW — Wave Loop 768 close-out / Wave Loop 769 setup (2026-07-23)
# NOW — Wave Loop 769 close-out / Wave Loop 770 setup (2026-07-24)

Last updated: 2026-07-23
Last updated: 2026-07-24

## Wave Loop 768 — module-scope `[355][2]^6 Pt` packed array-of-struct from call with indexed signed writes (Closes #1739)
## Wave Loop 769 — module-scope `[357][2]^6 Pt` packed array-of-struct from call with indexed signed writes (Closes #1740)

- Branch: `wave-loop-768`
- Issue: #1739
- Branch: `wave-loop-769`
- Issue: #1740
- PR: to open
- Report: `docs/reports/FPGA_LOOP_CLOSEOUT_W768_2026-07-23.md`
- Plan: `.claude/plans/wave-loop-768.md`
- Cooperation W769: `.claude/plans/wave-loop-769.md`
- Report: `docs/reports/FPGA_LOOP_CLOSEOUT_W769_2026-07-24.md`
- Plan: `.claude/plans/wave-loop-769.md`
- Cooperation W770: `.claude/plans/wave-loop-770.md`

### What landed
- `specs/scratch/w768_bench_module_355x2p6_aos_var_call_write.t27`
- 22,720 elements, 727,040-bit packed vector (~0.694 MiBit).
- Module-scope `pub var dst : [355][2]^6 Pt` initialized from a function call and
- `specs/scratch/w769_bench_module_357x2p6_aos_var_call_write.t27`
- 22,848 elements, 731,136-bit packed vector (~0.697 MiBit).
- Module-scope `pub var dst : [357][2]^6 Pt` initialized from a function call and
exercised with indexed signed field writes.
- `assert_eq` read-back in a `bench` block (Icarus path does not emit `assert_ne`).
- `scripts/gen_w768.py`
- Generator for the W768 witness; `OUTER = 355`, `MID_IDX = 177`.
- `scripts/gen_w769.py`
- Generator for the W769 witness; `OUTER = 357`, `MID_IDX = 178`.
- `bootstrap/tests/icarus_lowerable.rs`
- Added `accepts_w768_bench_module_355x2p6_aos_var_call_write`.
- `.trinity/experience.md`, `.trinity/current-issue.md`, `.claude/plans/wave-loop-769.md`
- W768 learnings saved and W769 issue/plan created.
- Added `accepts_w769_bench_module_357x2p6_aos_var_call_write`.
- `.trinity/experience.md`, `.trinity/current-issue.md`, `.claude/plans/wave-loop-770.md`
- W769 learnings saved and W770 issue/plan created.

### Not changed
- `bootstrap/src/compiler.rs` — zero compiler changes.
Expand All @@ -33,20 +33,20 @@ Last updated: 2026-07-23
- `cargo build --release -p t27c`: OK.
- `cargo test -p t27c --bin t27c`: 1494/0/2.
- `cargo test -p tri`: 78/0.
- `cargo test -p t27c --test icarus_lowerable`: 228/0.
- `t27c parse|icarus-lowerable|icarus-simulate|icarus-cocotb|seal --save` W768: PASS.
- `cargo test -p t27c --test icarus_lowerable`: 229/0.
- `t27c parse|icarus-lowerable|icarus-simulate|icarus-cocotb|seal --save` W769: PASS.

---

## Wave Loop 769 — next odd outer-dimension `[357][2]^6 Pt` (Issue #1740)
## Wave Loop 770 — next odd outer-dimension `[359][2]^6 Pt` (Issue #1741)

- Branch: `wave-loop-769` (to create after W768 merge)
- Issue: #1740
- Plan: `.claude/plans/wave-loop-769.md`
- Branch: `wave-loop-770` (to create after W769 merge)
- Issue: #1741
- Plan: `.claude/plans/wave-loop-770.md`

### Candidate variants
- Variant A (recommended): continue the odd outer-dimension ladder with `[357][2]^6 Pt`.
- Variant B: keep width at ~0.694 MiBit but move the packed var to bench/function scope.
- Variant A (recommended): continue the odd outer-dimension ladder with `[359][2]^6 Pt`.
- Variant B: keep width at ~0.697 MiBit but move the packed var to bench/function scope.
- Variant C: add `if`-guarded indexed signed field writes at the current width.

---
Expand Down
Loading
Loading