fix(witness): resolve the wide-rung pack defaults inside the repository - #1582
Open
gHashTag wants to merge 1 commit into
Open
fix(witness): resolve the wide-rung pack defaults inside the repository#1582gHashTag wants to merge 1 commit into
gHashTag wants to merge 1 commit into
Conversation
The six wide-rung witness decode references defaulted to an absolute path under /home/user/workspace when run with no argument, so the file a witnesses[] entry names failed on every machine but the one it was written on: FileNotFoundError: '/home/user/workspace/gf128_work/gf128_pack.json' That matters more than an ordinary broken default. These are the artifacts honesty rule #10 points a sceptical reader at, and running the named file is the first thing anyone checking the corpus does. The witnesses themselves are sound. Passing the in-repo pack explicitly already gave the claimed result -- gf128 15/15 exact, abs_error=0 -- so nothing about the decoding changes here, only where the default input is looked up. The cross_check_representative.py scripts were never affected, since they import these modules rather than invoking __main__. The default now resolves relative to the script's own location. All six run standalone afterwards and print their own verdict at abs_error=0, gf48 through gf1024. Found by extending the pass-49 "just run everything" sweep to tools/ and scripts/, after triaging 300 files by side effect so only the 79 with no write, exec, network or git call were executed unattended. Closes #1581
Contributor
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The six wide-rung witness decode references default to an absolute path under
/home/user/workspacewhen run with no argument:So the file a
witnesses[]entry names fails on every machine but the one it was written on:This matters more than an ordinary broken default, because these are the artifacts honesty rule #10 points a sceptical reader at. Following the witness trail and running the named file is the first thing anyone checking the corpus does, and it currently fails.
The witnesses themselves are sound
Passing the in-repo pack explicitly gives the claimed result immediately:
Nothing about the decoding is wrong — only where the default input is looked up. The
cross_check_representative.pyscripts are unaffected, since they import these modules rather than invoking__main__; all three reproduce 201,512/201,512 agreeing codes.Fix
Resolve the default relative to the script's own location. After the change all six run standalone:
Related, not fixed here
A wider sweep of
scripts/found 32 files carrying/Users/playra/t27— another absolute home directory, on a machine that is not the repository. None is referenced by any workflow, so CI is unaffected, and they are left alone rather than bulk-edited. Reported for visibility:scripts/gen_w367_lean.pythroughgen_w392_lean.pyandscripts/fix_v09_latex.pyamong them.Closes #1581