fix(crypto): real Noise ee+es+se key agreement (forward secrecy) — part 1 of N3#65
Draft
gHashTag wants to merge 1 commit into
Draft
fix(crypto): real Noise ee+es+se key agreement (forward secrecy) — part 1 of N3#65gHashTag wants to merge 1 commit into
gHashTag wants to merge 1 commit into
Conversation
…rt 1 of N3 The handshake computed only ee + ss and passed `ss` in BOTH the es and se slots, so it had no forward secrecy and did not bind ephemerals into the session. Fix: NoiseXX.ephemeral becomes a reusable StaticSecret (EphemeralSecret is consumed by its first diffie_hellman; we need two), and complete_initiator/ responder compute the real ee/es/se so both sides derive the same key. Verified: handshake_and_roundtrip + independent_handshakes pass, full suite 103 passed. SCOPE: forward-secrecy half of N3 only. Identity auth (allow-list gating -> the actual MITM defense), N4 (HELLO MAC), N5 (keystore) remain open per RFC #63 and need owner sign-off. Based on the pipeline-guard branch (needs #60's build fix). Draft — needs crypto review. Refs #58, #63. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> phi^2 + phi^-2 = 3
This was referenced Jul 10, 2026
Owner
Author
Triage — KEEP (stacked on #60)Verdict: KEEP as legitimate stacked PR.
Cascade dependency: blocks on same regen as docs PRs. Merge order: after #60 merges, this can retarget base to No action here until #60 lands and CI baseline is green. phi^2 + phi^-2 = 3 |
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #60 (pipeline-guard). First verifiable slice of the crypto fix (RFC #63): the handshake did ee+ss with ss as both es/se (no forward secrecy); now real ee/es/se. Verified honest parties still agree (handshake_and_roundtrip green), 103 tests pass. Identity auth (allow-list), N4, N5 still open per #63. Draft, needs crypto review. phi^2 + phi^-2 = 3