fix: library compiles again — two spec defects + regenerated gen/rust - #94
Closed
gHashTag wants to merge 2 commits into
Closed
fix: library compiles again — two spec defects + regenerated gen/rust#94gHashTag wants to merge 2 commits into
gHashTag wants to merge 2 commits into
Conversation
`cargo fmt --all --check` has been failing on main since 2026-07-23 and blocks every PR, including documentation-only ones. Formatter output only, three files, no logic changes. Does not make CI green on its own: `cargo build` fails separately with 31 errors in tracked generated code under gen/rust/ (26x E0107 bare `Vec`, E0425 lowercase constant reference, 3x E0308, E0277). That is a generator defect and belongs upstream in the Rust backend. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
… backend The library did not compile: 32 errors across 9 generated modules, CI red since 2026-07-23. Root cause was split between the t27 Rust backend and two genuine defects in our own specs. The backend half is gHashTag/t27#1573. This commit carries our half plus the regenerated output. Spec defect 1, specs/multipath_routing.t27:128 — a duplicated comparison: if (get_path_valid(...) == path_valid == PATH_VALID) `path_valid` in lower case does not exist; the constant is PATH_VALID. The generator reproduced the typo faithfully, which is the behaviour we want from it. Corrected to a single comparison. Spec defect 2, specs/etx.t27:45 — `fp_mul(256 - alpha, est)` where alpha is u8. 256 does not fit in u8. The Q0.8 complement is 255 - alpha, which is what the code now says. This changes the numeric contract by 1/256 in the EWMA weight; flagged for review rather than assumed correct. Regenerated all 86 modules with the fixed backend. Result: the library compiles clean and 101 library tests pass. Still red, and now visible for the first time: three binaries import modules that do not exist anywhere in the repository — tri_rti.rs wants `rti`, `tri_beamform` and `tri_video_fusion`, trios_meshd_video.rs wants `video_bridge` (which exists only as generated code, unwired), and smoke_m1.rs wants `Handshake`, `MeshError` and `Node` re-exports. Those failures were masked while the library itself was broken. Not addressed here: writing the missing modules is authorship, not repair. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Owner
Author
|
Включено в #97, который смержен: там и cargo fmt, и исправления генератора с перегенерацией. Закрываю в его пользу. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainhas not compiled since 2026-07-23: 32 errors across 9 generated modules. This fixes our half. Companion: gHashTag/t27#1573 (the Rust backend).Stacked on #93 (
cargo fmt), which must land first.Result
cargo test --lib: 101 passed, 0 failedcargo fmt --all --check: cleanTwo defects were ours, not the generator's
specs/multipath_routing.t27:128— a duplicated comparison:path_validin lower case does not exist; the constant isPATH_VALID. The generator reproduced the typo faithfully — which is exactly what a spec-first toolchain should do. Corrected to a single comparison.specs/etx.t27:45—fp_mul(256 - alpha, est)withalpha: u8. 256 does not fit inu8. The Q0.8 complement is255 - alpha.255 - alphais the standard 8-bit complement and is what the signature forces, but if the intent was exact1.0 = 256thenfp_mulshould widen instead. I did not assume.Newly visible: three binaries import modules that do not exist
These were masked while the library itself was broken.
cargo buildstill fails on them (24 errors):src/bin/tri_rti.rsrti,tri_beamform,tri_video_fusion— no such files anywhere in the reposrc/bin/trios_meshd_video.rsvideo_bridge— exists asgen/rust/video_bridge.rs, never wired intosrc/lib.rssrc/bin/smoke_m1.rsHandshake,MeshError,Nodere-exportssrc/bin/trios_meshd.rssend/recvagainst aTransporttrait that declares them, but with a mismatched signature (E0407)video_bridgelooks like a one-line wiring fix. The other three binaries reference code that was never committed or was deleted; writing it is authorship, not repair, so I left them alone.🤖 Generated with Claude Code