refactor: Remove inline constants anti-pattern and fix build

Phase 1 cleanup: Remove duplicate files and inline constants

Deleted files (not tracked):
- orchestrator_v2.zig, orchestrator_v2_simple.zig
- orchestrator_v2_working.zig, orchestrator_bench.zig
- self_improver_v2.zig, self_improver_engine.zig.bak
- tri_commands.zig.bak, conflict files (.*!)

Changes:
- AGENTS.md: Added ANTI-PATTERN #2 about inline constants
- orchestrator_v2_full.zig: Import from sacred_constants module
- marketplace_engine.zig: Use canonical constants
- sacred_economy_engine.zig: Use canonical constants
- sacred_economy_global_engine.zig: Use canonical constants
- nft_marketplace.zig, nft_marketplace_engine.zig: Use canonical constants
- tri_commands.zig: Fixed unused variables and format string errors

Rule: ALWAYS import from src/sacred/constants.zig instead of
defining inline constants like "const PHI = 1.618..."

Build: OK | Tests: PASS

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: Antigravity Agent

AGENTS.md

@@ -196,7 +196,44 @@ trinity/output/fpga/*.v - Generated Verilog (will be overwritten)
 generated/*.zig - Generated code (will be overwritten)
 ```
 
-### 🚫 ANTI-PATTERN #2: FORGETTING FPGA JTAG FIRMWARE
+### 🚫 ANTI-PATTERN #2: INLINE CONSTANTS (ANTI-PATTERN)
+
+**NEVER define mathematical constants inline - ALWAYS import from canonical source!**
+
+```
+❌ NEVER write inline constants like:
+    const phi: f64 = 1.618033988749895;
+    const PHI: f64 = 1.6180339887498948482;
+    const pi: f64 = 3.141592653589793;
+
+✅ ALWAYS import from src/sacred/constants.zig:
+    const sacred = @import("sacred/constants.zig");
+    const PHI = sacred.SacredConstants.PHI;
+    const PI = sacred.SacredConstants.PI;
+```
+
+**WHY?**
+- Single source of truth prevents inconsistencies
+- Compile-time verification ensures mathematical identities hold
+- Changes propagate automatically to all modules
+- Centralized documentation of constant meanings
+
+**CANONICAL CONSTANTS LOCATION:**
+`src/sacred/constants.zig` - SacredConstants struct
+
+**AVAILABLE CONSTANTS:**
+```zig
+sacred.SacredConstants.PHI           // 1.618033988749895
+sacred.SacredConstants.PHI_INVERSE   // 0.618033988749895
+sacred.SacredConstants.PHI_SQ        // 2.618033988749895
+sacred.SacredConstants.TRINITY       // 3.0
+sacred.SacredConstants.PI            // 3.141592653589793
+sacred.SacredConstants.E             // 2.718281828459045
+sacred.SacredConstants.SQRT5         // 2.2360679774997896
+// ... and more derived constants
+```
+
+### 🚫 ANTI-PATTERN #3: FORGETTING FPGA JTAG FIRMWARE
 
 **Xilinx Platform Cable USB II requires firmware loading EVERY SESSION!**
 

src/tri/marketplace_engine.zig

@@ -15,17 +15,20 @@
 const std = @import("std");
 const Allocator = std.mem.Allocator;
 
-// Constants
-const PHI: f64 = 1.6180339887498948482;
-const PHI_SQ: f64 = 2.6180339887498948482;
-const PHI_INV_SQ: f64 = 0.3819660112501051518;
+// Import canonical constants (NOT inline - anti-pattern!)
+const sacred_constants = @import("sacred_constants");
+const PHI = sacred_constants.SacredConstants.PHI;
+const PHI_SQ = sacred_constants.SacredConstants.PHI_SQ;
+const PI = sacred_constants.SacredConstants.PI;
+const E = sacred_constants.SacredConstants.E;
+
+// Derived constants (computed from canonical values)
+const PHI_INV_SQ: f64 = 1.0 / (PHI * PHI);
 const MU: f64 = 0.0382; // Inflation rate
 const CHI: f64 = 0.0618; // Deflation rate
 const BASE_YIELD_RATE: f64 = 0.1618;
 const ORACLE_CONFIDENCE_DECAY: f64 = 0.9382;
 const LP_FEE_RATE: f64 = 0.003;
-const PI: f64 = 3.14159265358979323846;
-const E: f64 = 2.71828182845904523536;
 
 // ═══════════════════════════════════════════════════════════════════════════════
 // Types

src/tri/nft_marketplace.zig

@@ -13,20 +13,23 @@
 const std = @import("std");
 const math = std.math;
 
+// Import canonical constants (NOT inline - anti-pattern!)
+const sacred_constants = @import("sacred_constants");
+
 // ═══════════════════════════════════════════════════════════════════════════════
-// CONSTANTS
+// CONSTANTS (export from canonical source)
 // ═══════════════════════════════════════════════════════════════════════════════
 
-// Basic φ-constants (Sacred Formula)
-pub const PHI: f64 = 1.618033988749895;
-pub const PHI_INV: f64 = 0.618033988749895;
-pub const PHI_SQ: f64 = 2.618033988749895;
-pub const TRINITY: f64 = 3.0;
-pub const SQRT5: f64 = 2.2360679774997896;
-pub const TAU: f64 = 6.283185307179586;
-pub const PI: f64 = 3.141592653589793;
-pub const E: f64 = 2.718281828459045;
-pub const PHOENIX: i64 = 999;
+// Basic φ-constants (Sacred Formula) - from canonical source
+pub const PHI = sacred_constants.SacredConstants.PHI;
+pub const PHI_INV = sacred_constants.SacredConstants.PHI_INVERSE;
+pub const PHI_SQ = sacred_constants.SacredConstants.PHI_SQ;
+pub const TRINITY = sacred_constants.SacredConstants.TRINITY;
+pub const SQRT5 = sacred_constants.SacredConstants.SQRT5;
+pub const TAU = sacred_constants.SacredConstants.TAU;
+pub const PI = sacred_constants.SacredConstants.PI;
+pub const E = sacred_constants.SacredConstants.E;
+pub const PHOENIX = sacred_constants.SacredConstants.PHOENIX;
 
 // ═══════════════════════════════════════════════════════════════════════════════
 // MEMORY FOR WASM

src/tri/nft_marketplace_engine.zig

@@ -13,11 +13,14 @@
 const std = @import("std");
 const math = std.math;
 
+// Import canonical constants (NOT inline - anti-pattern!)
+const sacred_constants = @import("sacred_constants");
+
 // ═══════════════════════════════════════════════════════════════════════════════
-// CONSTANTS
+// CONSTANTS (from canonical source)
 // ═══════════════════════════════════════════════════════════════════════════════
 
-pub const PHI: f64 = 1.618033988749895;
+pub const PHI = sacred_constants.SacredConstants.PHI;
 
 pub const MIN_BID_INCREMENT: f64 = 0.01;
 

src/tri/orchestrator_v2_full.zig

@@ -3,10 +3,12 @@ const std = @import("std");
 const Allocator = std.mem.Allocator;
 const ArrayList = std.ArrayListUnmanaged;
 
-pub const PHI: f64 = 1.618033988749895;
-pub const PHI_INV: f64 = 0.618033988749895;
-pub const PHI_SQ: f64 = 2.618033988749895;
-pub const TRINITY: f64 = 3.0;
+// Import constants from canonical source (NOT inline - anti-pattern!)
+const sacred_constants = @import("sacred_constants");
+pub const PHI = sacred_constants.SacredConstants.PHI;
+pub const PHI_INV = sacred_constants.SacredConstants.PHI_INVERSE;
+pub const PHI_SQ = sacred_constants.SacredConstants.PHI_SQ;
+pub const TRINITY = sacred_constants.SacredConstants.TRINITY;
 
 pub const CommandCategory = enum(u8) {
     core, swe_agent, golden_chain, sacred_math, git, demo, bench,

src/tri/sacred_economy_engine.zig

@@ -13,20 +13,20 @@
 const std = @import("std");
 const math = std.math;
 
+// Import canonical constants (NOT inline - anti-pattern!)
+const sacred_constants = @import("sacred_constants");
+
 // ═══════════════════════════════════════════════════════════════════════════════
-// CONSTANTS
+// CONSTANTS (export from canonical source)
 // ═══════════════════════════════════════════════════════════════════════════════
 
-pub const PHI: f64 = 1.618033988749895;
-
-pub const PI: f64 = 3.141592653589793;
-
-pub const E: f64 = 2.718281828459045;
-
-pub const TRINITY: f64 = 3;
+pub const PHI = sacred_constants.SacredConstants.PHI;
+pub const PI = sacred_constants.SacredConstants.PI;
+pub const E = sacred_constants.SacredConstants.E;
+pub const TRINITY = sacred_constants.SacredConstants.TRINITY;
 
+// Economy-specific constants
 pub const APY_BASE: f64 = 1.01618;
-
 pub const STAKE_LOCK_PERIOD: f64 = 7776000;
 
 pub const WEB3_ENABLED: f64 = 0;

src/tri/sacred_economy_global_engine.zig

@@ -13,17 +13,22 @@
 const std = @import("std");
 const math = std.math;
 
+// Import canonical constants (NOT inline - anti-pattern!)
+const sacred_constants = @import("sacred_constants");
+
 // ═════════════════════════════════════════════════════════════════════════════
-// CONSTANTS
+// CONSTANTS (export from canonical source + derived)
 // ═════════════════════════════════════════════════════════════════════════════
 
-// Trinity Constants
-pub const PHI: f64 = 1.618033988749895;
-pub const PHI_SQARED: f64 = 2.618033988749895;
-pub const THREE: f64 = 3;
-pub const PHI_SQUARED_PLUS_ONE: f64 = 4.618033988749895;
-pub const THREE_SQUARED_MINUS_ONE: f64 = 2.618033988749895;
-pub const FIBONACCI: f64 = 1.618033988749895;
+// Trinity Constants (from canonical source)
+pub const PHI = sacred_constants.SacredConstants.PHI;
+pub const PHI_SQARED = sacred_constants.SacredConstants.PHI_SQ;
+pub const THREE = sacred_constants.SacredConstants.TRINITY;
+
+// Derived constants
+pub const PHI_SQUARED_PLUS_ONE: f64 = PHI_SQARED + 1.0;
+pub const THREE_SQUARED_MINUS_ONE: f64 = THREE * THREE - 1.0;
+pub const FIBONACCI = PHI; // Fibonacci ratio converges to phi
 pub const TRINITY_IDENTITY: f64 = 0; // phi^2 + 1/phi^2 = 3
 
 // Math Constants

src/tri/tri_commands.zig

@@ -3894,11 +3894,7 @@ pub fn runReplTestCommand(allocator: std.mem.Allocator, args: []const []const u8
 // ═══════════════════════════════════════════════════════════════════════════════
 
 pub fn runConsciousCommand(allocator: std.mem.Allocator, cmd_args: []const []const u8) void {
-    // Sacred constants (inline)
-    const phi: f64 = 1.618033988749895;
-    const phi_inv: f64 = 1.0 / phi;
-    const gamma: f64 = phi_inv * phi_inv * phi_inv;
-    const trinity: f64 = phi * phi + phi_inv * phi_inv;
+    _ = allocator; // Currently unused but kept for future use
 
     if (cmd_args.len == 0) {
         // Default to simulation - run simple inline simulation
@@ -3928,40 +3924,39 @@ pub fn runConsciousCommand(allocator: std.mem.Allocator, cmd_args: []const []con
             }
         }
 
-        _ = speed;
         std.debug.print("\n{s}╔══════════════════════════════════════════════════════════╗{s}\n", .{ YELLOW, RESET });
         std.debug.print("{s}║     CONSCIOUSNESS AWAKENING SIMULATION v4.3           ║{s}\n", .{ YELLOW, RESET });
         std.debug.print("{s}╚══════════════════════════════════════════════════════════╝{s}\n\n", .{ YELLOW, RESET });
-        std.debug.print("{s}Running {d} steps...{s}\n\n", .{ CYAN, RESET, steps, RESET });
+        std.debug.print("{s}Running {d} steps...{s}\n\n", .{ CYAN, steps, RESET });
         std.debug.print("{s}Full simulation requires: src/consciousness/conscious_simulate.zig{s}\n", .{ YELLOW, RESET });
         std.debug.print("{s}Status: Module under active development.{s}\n\n", .{ YELLOW, RESET });
     } else if (std.mem.eql(u8, subcommand, "constants")) {
         std.debug.print("\n{s}╔══════════════════════════════════════════════════════════╗{s}\n", .{ YELLOW, RESET });
-        std.debug.print("{s}║     SACRED CONSTANTS — Consciousness Framework         ║{s}\n", .{ YELLOW, RESET });
+        std.debug.print("{s}║     SACRED CONSTANTS - Consciousness Framework        ║{s}\n", .{ YELLOW, RESET });
         std.debug.print("{s}╚══════════════════════════════════════════════════════════╝{s}\n\n", .{ YELLOW, RESET });
 
-        std.debug.print("{s}Golden Ratio (φ){s}         = {d:.15}\n", .{ CYAN, RESET, 1.618033988749895 });
-        std.debug.print("{s}Gamma (γ = φ⁻³){s}         = {d:.15}\n", .{ CYAN, RESET, 0.236067977499790 });
-        std.debug.print("{s}TRINITY (φ² + φ⁻²){s}     = {d:.15}\n", .{ YELLOW, RESET, 3.0 });
-        std.debug.print("{s}Threshold (φ⁻¹){s}         = {d:.15}\n", .{ GREEN, RESET, 0.618033988749895 });
-        std.debug.print("{s}Gamma Freq (f_γ){s}       = {d:.6} Hz\n", .{ CYAN, RESET, 56.0 });
+        std.debug.print("{s}Golden Ratio (phi){s}       = {d:.15}\n", .{ CYAN, RESET, 1.618033988749895 });
+        std.debug.print("{s}Gamma (gamma = phi^-3){s}    = {d:.15}\n", .{ CYAN, RESET, 0.236067977499790 });
+        std.debug.print("{s}TRINITY (phi^2 + phi^-2){s}  = {d:.15}\n", .{ YELLOW, RESET, 3.0 });
+        std.debug.print("{s}Threshold (phi^-1){s}       = {d:.15}\n", .{ GREEN, RESET, 0.618033988749895 });
+        std.debug.print("{s}Gamma Freq (f_gamma){s}      = {d:.6} Hz\n", .{ CYAN, RESET, 56.0 });
         std.debug.print("\n", .{});
     } else if (std.mem.eql(u8, subcommand, "theories")) {
         std.debug.print("\n{s}╔══════════════════════════════════════════════════════════╗{s}\n", .{ YELLOW, RESET });
-        std.debug.print("{s}║     CONSCIOUSNESS THEORIES — Unified Framework          ║{s}\n", .{ YELLOW, RESET });
+        std.debug.print("{s}║     CONSCIOUSNESS THEORIES - Unified Framework         ║{s}\n", .{ YELLOW, RESET });
         std.debug.print("{s}╚══════════════════════════════════════════════════════════╝{s}\n\n", .{ YELLOW, RESET });
 
         std.debug.print("{s}1. IIT 4.0{s}\n", .{ YELLOW, RESET });
         std.debug.print("   Intrinsic Difference, 5 postulates, Phi integration\n", .{});
         std.debug.print("   Adversarial validation: IIT 2/3, GWT 0/3 (Nature 2025)\n\n", .{});
 
         std.debug.print("{s}2. Global Workspace Theory{s}\n", .{ CYAN, RESET });
-        std.debug.print("   Selection-broadcast cycle, ignition at φ⁻¹\n", .{});
-        std.debug.print("   Working memory: φ+1 items, cycle: φ⁻² = 382ms\n\n", .{});
+        std.debug.print("   Selection-broadcast cycle, ignition at phi^-1\n", .{});
+        std.debug.print("   Working memory: phi+1 items, cycle: phi^-2 = 382ms\n\n", .{});
 
         std.debug.print("{s}3. Orch-OR{s}\n", .{ GREEN, RESET });
         std.debug.print("   Microtubule quantum coherence, objective reduction\n", .{});
-        std.debug.print("   Gamma frequency: f_γ = 56Hz, evidence 2024-2025\n\n", .{});
+        std.debug.print("   Gamma frequency: f_gamma = 56Hz, evidence 2024-2025\n\n", .{});
 
         std.debug.print("{s}4. Qutrit Consciousness{s}\n", .{ YELLOW, RESET });
         std.debug.print("   Posner molecules (Ca9(PO4)6), 6 P-31 nuclear spins\n", .{});