fix(history): add error logging to silent catch {} handlers#170
Merged
Conversation
Replace empty catch {} handlers with proper error logging using
std.log.debug for consistency. This prevents persistence failures
from being silently swallowed.
Changes:
- History.add(): log save errors
- ReplHistory.load(): log load errors
- ReplHistory.saveBeforeExit(): log save errors
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gHashTag
added a commit
that referenced
this pull request
Mar 18, 2026
fix(history): add error logging to silent catch {} handlers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
catch {}handlers with proper error logging insrc/tri/tri_history.zigstd.log.debugfor consistency as specified in the issueChanges
History.add(): log save errors instead of silently swallowingReplHistory.load(): log load errors instead of silently swallowingReplHistory.saveBeforeExit(): log save errors instead of silently swallowingTest plan
zig test src/tri/tri_history.zig— All 5 tests passcatch {}handlers remaining in filestd.log.debugCloses #167
🤖 Generated with Claude Code