Skip to content

fix(history): add error logging to silent catch {} handlers #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gHashTag merged 1 commit into from
Mar 11, 2026
Merged

fix(history): add error logging to silent catch {} handlers #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/tri/tri_history.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ pub const History = struct {
}

// Save to file
self.save() catch {};
self.save() catch |err| {
std.log.debug("history save: {s}", .{@errorName(err)});
};
}

/// Navigate to previous command
Expand Down Expand Up @@ -252,7 +254,9 @@ pub const ReplHistory = struct {

/// Load history from file
pub fn load(self: *ReplHistory) !void {
self.history.load() catch {};
self.history.load() catch |err| {
std.log.debug("history load: {s}", .{@errorName(err)});
};
}

/// Save current input and clear
Expand Down Expand Up @@ -312,7 +316,9 @@ pub const ReplHistory = struct {

/// Save history before exit
pub fn saveBeforeExit(self: *ReplHistory) void {
self.history.save() catch {};
self.history.save() catch |err| {
std.log.debug("history save: {s}", .{@errorName(err)});
};
}
};

Expand Down
Loading