fix(mcp-client): add child.deinit() in spawn error path#172
Merged
Conversation
When child.spawn() fails, the child process resources were leaking. Added child.deinit() call before the early return to properly clean up. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gHashTag
added a commit
that referenced
this pull request
Mar 18, 2026
fix(mcp-client): add child.deinit() in spawn error path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/tri-api/mcp_client.zigwherechild.deinit()was not called whenchild.spawn()failedchild.deinit()before the early return in the spawn error path (line 60)Changes
src/tri-api/mcp_client.zig: Addedchild.deinit()call in the spawn error handlerTest Plan
zig fmt src/tri-api/mcp_client.zigpasses (syntax valid)zig ast-check src/tri-api/mcp_client.zigpassesCloses #166
🤖 Generated with Claude Code