fix(ci): install shared lib, add cgo include, fix Python/C++ paths

- build.zig: use addInstallArtifact in shared step (was only compiling, not installing)
- go/goldenfloat/gf16.go: add #include "gf16.h" to cgo preamble
- python/_binding.py: honor GOLDENFLOAT_LIB_DIR env, add restype for phi/trinity/version
- cpp/CMakeLists.txt: search $GOLDENFLOAT_LIB_DIR in find_library
- CI: remove conflicting CGO env vars, let cgo relative paths work

Author: gHashTag

.github/workflows/test-bindings.yml

@@ -99,6 +99,6 @@ jobs:
         if: matrix.language == 'go'
         run: |
           cd go/goldenfloat
-          CGO_CFLAGS="-I$GITHUB_WORKSPACE/src/c" CGO_LDFLAGS="-L$GITHUB_WORKSPACE/zig-out/lib -lgoldenfloat" go test -v ./...
+          go test -v ./...
         env:
           LD_LIBRARY_PATH: ${{ github.workspace }}/zig-out/lib

build.zig

@@ -56,13 +56,13 @@ pub fn build(b: *std.Build) void {
         .version = .{ .major = 2, .minor = 1, .patch = 0 },
     });
 
-    b.installArtifact(c_abi_lib);
+    const install_lib = b.addInstallArtifact(c_abi_lib);
 
     // Install C header alongside library
     const header_install = b.addInstallHeaderFile(b.path("src/c/gf16.h"), "gf16.h");
 
     const shared_step = b.step("shared", "Build C-ABI shared library (libgoldenfloat)");
-    shared_step.dependOn(&c_abi_lib.step);
+    shared_step.dependOn(&install_lib.step);
     shared_step.dependOn(&header_install.step);
 
     // ─────────────────────────────────────────────────────────────────

cpp/CMakeLists.txt

@@ -8,12 +8,12 @@ project(goldenfloat VERSION 1.0.0 LANGUAGES CXX)
 
 # Find GoldenFloat shared library
 find_library(GOLDENFLOAT NAMES goldenfloat PATHS
+    "$ENV{GOLDENFLOAT_LIB_DIR}"
     "${CMAKE_SOURCE_DIR}/../../zig-out/lib"
     "${CMAKE_SOURCE_DIR}/../zig-out/lib"
     "${CMAKE_SOURCE_DIR}/../../zig-out/bin"
     "${CMAKE_SOURCE_DIR}/../../build"
     "${CMAKE_SOURCE_DIR}/../../zig-out/lib"
-    NO_DEFAULT_PATH
 )
 
 if(NOT GOLDENFLOAT)

go/goldenfloat/gf16.go

@@ -8,6 +8,7 @@ package goldenfloat
 /*
 #cgo LDFLAGS: -L../../zig-out/lib -lgoldenfloat
 #cgo CFLAGS: -I../../src/c
+#include "gf16.h"
 */
 import "C"
 

python/goldenfloat/_binding.py

@@ -16,13 +16,16 @@
 
 def _find_library():
     """Find libgoldenfloat.{so,dylib,dll}"""
-    # Check zig-out/lib first
     search_paths = [
         os.path.join(os.path.dirname(__file__), "..", "..", "zig-out", "lib"),
         os.path.join(os.path.dirname(__file__), "..", "..", "..", "..", "zig-out", "lib"),
+        os.path.join(os.getcwd(), "zig-out", "lib"),
     ]
 
-    # Add current directory for development
+    env_dir = os.environ.get("GOLDENFLOAT_LIB_DIR")
+    if env_dir:
+        search_paths.insert(0, env_dir)
+
     search_paths.append(os.getcwd())
 
     lib_name = None
@@ -126,6 +129,15 @@ def _get_lib():
         _lib.gf16_fma.restype = _gf16_t
         _lib.gf16_fma.argtypes = [_gf16_t, _gf16_t, _gf16_t]
 
+        _lib.goldenfloat_phi.restype = ctypes.c_double
+        _lib.goldenfloat_phi.argtypes = []
+
+        _lib.goldenfloat_trinity.restype = ctypes.c_double
+        _lib.goldenfloat_trinity.argtypes = []
+
+        _lib.goldenfloat_version.restype = ctypes.c_char_p
+        _lib.goldenfloat_version.argtypes = []
+
     return _lib