Skip to content

Commit 60c10fd

Browse files
committed
fix(ci): remove trinity_constants, fix build.zig install, fix Go tests
- Remove src/trinity_constants.zig (pulled from wrong branch, had type error) - build.zig: use addInstallArtifact for shared library, remove trinity_constants test reference - Go tests: use FromF32 roundtrip instead of raw constants (GF16_ONE constant 0x3C00 doesn't match library encoding), handle string inputs
1 parent 77e8a1b commit 60c10fd

3 files changed

Lines changed: 206 additions & 487 deletions

File tree

build.zig

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -56,13 +56,12 @@ pub fn build(b: *std.Build) void {
5656
.version = .{ .major = 1, .minor = 1, .patch = 0 },
5757
});
5858

59-
b.installArtifact(c_abi_lib);
59+
const c_abi_install = b.addInstallArtifact(c_abi_lib, .{});
6060

61-
// Install C header alongside library
6261
const header_install = b.addInstallHeaderFile(b.path("src/c/gf16.h"), "gf16.h");
6362

6463
const shared_step = b.step("shared", "Build C-ABI shared library (libgoldenfloat)");
65-
shared_step.dependOn(&c_abi_lib.step);
64+
shared_step.dependOn(&c_abi_install.step);
6665
shared_step.dependOn(&header_install.step);
6766

6867
// ─────────────────────────────────────────────────────────────────
@@ -112,17 +111,6 @@ pub fn build(b: *std.Build) void {
112111
const run_tests = b.addRunArtifact(formats_tests);
113112
const run_transcendent_tests = b.addRunArtifact(transcendent_tests);
114113

115-
const trinity_tests_root = b.createModule(.{
116-
.root_source_file = b.path("src/trinity_constants.zig"),
117-
.target = target,
118-
.optimize = optimize,
119-
});
120-
const trinity_tests = b.addTest(.{
121-
.name = "trinity-constants-tests",
122-
.root_module = trinity_tests_root,
123-
});
124-
const run_trinity_tests = b.addRunArtifact(trinity_tests);
125-
126114
const phi_attention_tests_root = b.createModule(.{
127115
.root_source_file = b.path("src/phi_attention.zig"),
128116
.target = target,
@@ -160,7 +148,6 @@ pub fn build(b: *std.Build) void {
160148
test_step.dependOn(&run_tests.step);
161149
test_step.dependOn(&run_transcendent_tests.step);
162150
test_step.dependOn(&run_c_abi_tests.step);
163-
test_step.dependOn(&run_trinity_tests.step);
164151
test_step.dependOn(&run_phi_attention_tests.step);
165152
test_step.dependOn(&run_trinity_init_tests.step);
166153
test_step.dependOn(&run_jepa_t_tests.step);

0 commit comments

Comments
 (0)