[26.0] Fix incremental rebuild of the ToolShed search index#22650
Open
bgruening wants to merge 2 commits into
Open
[26.0] Fix incremental rebuild of the ToolShed search index#22650bgruening wants to merge 2 commits into
bgruening wants to merge 2 commits into
Conversation
bgruening
changed the title
mvdbeek
reviewed
May 8, 2026
| if indexed_document["full_last_updated"] == repo.get("full_last_updated"): | ||
| # We're done, since we sorted repos by update time | ||
| break | ||
| # Something is wrong here Repository.update_time is not "full_last_updated". |
Member
There was a problem hiding this comment.
This is effectively doing a full rebuild. That's better than nothing but I guess the actual bug is in te get_repos function
4 tasks
Member
Author
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref: galaxyproject/infrastructure-playbook#60
@natefoo maybe that fixes the TS?
I think the bigger underlying issue is that
Repository.update_timeis not updated, maybe ...