[26.0] Fix workflow rerun for unset optional data inputs#22664
Merged
mvdbeek merged 2 commits intoMay 18, 2026
Conversation
Re-running a workflow that has an optional `data_input` /
`data_collection_input` step left empty on the original run failed with a
pydantic `DataOrCollectionRequest` ValidationError ("'values' not
permitted" against `DataRequestHdca`/`FileRequestUri`/
`DataRequestCollectionUri`). `WorkflowInvocationRequestModel.inputs`
returns `null` for unset optional inputs; WorkflowRunFormSimple.vue
wrapped that as `{values: [null]}` regardless, and the resulting
`null` entry crashed `FormData.vue`'s `onMounted` hook on
`"src" in null`. Because the mounted hook never completed, the bad
wrapper survived in formData and was sent to the server.
Filter `null`/`undefined` entries out of the rerun-hydrated array, and
skip the assignment entirely when no real values remain so the form
falls back to its default for the optional input. Sibling fix to galaxyproject#22601.
mvdbeek
changed the title
jmchilton
approved these changes
May 9, 2026
Member
|
I approved this already but it looks like the failing tests are related. |
mvdbeek
force-pushed
the
fix-rerun-validation
branch
from
364b3bc to
0fbea9e
Compare
Selenium regression for the WorkflowRunFormSimple data-input rerun hydration crash fixed in the prior commit. Runs `WORKFLOW_OPTIONAL_TRUE_INPUT_DATA` (a single optional `data_input`) without selecting a dataset, then reruns without changes and asserts a new ok output appears. Pre-fix, the rerun submission raised a "Workflow submission failed: ... 'values' not permitted ..." toast because the rerun-hydrated wrapper contained `[null]` (left over from the optional input the user didn't fill on the original run) and `FormData.vue`'s mounted hook crashed on `"src" in null` before it could normalize the value. Originally reported on a "1 or 2 haplotypes" workflow where users left the second-haplotype input empty.
mvdbeek
force-pushed
the
fix-rerun-validation
branch
2 times, most recently
from
92a6b3e to
394aac4
Compare
github-project-automation
Bot
moved this from Needs Review
to Done
in Galaxy Dev - weeklies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
How to test the changes?
(Select all options that apply)
License