Skip to content

Commit 6570f77

Browse files
committed
fix: resolve Semgrep shell injection and zizmor warnings
- Use env var instead of inline ${{ inputs.mode }} in sync-settings composite action to prevent shell injection (Semgrep finding) - Add if: always() to Trivy step so it runs regardless of Semgrep result, preventing missing SARIF upload - Set zizmor secrets-outside-env to info level (acceptable for single-admin personal account without GitHub Environments)
1 parent b98ffb2 commit 6570f77

3 files changed

Lines changed: 4 additions & 1 deletion

File tree

.github/actions/security-scan/action.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ runs:
1616
config: auto
1717

1818
- name: Run Trivy vulnerability scanner
19+
if: always()
1920
uses: aquasecurity/trivy-action@57a97c7e7821a5776cebc9bb87c984fa69cba8f1 # v0.35.0
2021
with:
2122
scan-type: fs

.github/actions/sync-settings/action.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,9 @@ runs:
3636
env:
3737
GH_TOKEN: ${{ inputs.github_token }}
3838
REPORT_FILE: reports/sync-report.md
39+
SYNC_MODE: ${{ inputs.mode }}
3940
run: |
40-
./scripts/sync-repo-settings.sh "${{ inputs.mode }}"
41+
./scripts/sync-repo-settings.sh "$SYNC_MODE"
4142
echo "report_file=reports/sync-report.md" >> "$GITHUB_OUTPUT"
4243
4344
- name: Parse report

zizmor.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,4 @@ rules:
33
config:
44
policies:
55
"*": ref-pin
6+
secrets-outside-env: info

0 commit comments

Comments
 (0)