Merge pull request #46 from gambitph/feat/37-video-audio-bulk

feat: add video and audio bulk optimization

Author: bfintal

src/admin/class-meta-box.php

@@ -123,6 +123,12 @@ function cimo_get_media_type_label( $mimetype ) {
 							$optimization_savings = number_format( 100 * ( $original_filesize - $converted_filesize ) / $original_filesize, 2 );
 						}
 
+						// If optimization savings is not a valid number or is negative, do not display it
+						if ( ! is_numeric( $optimization_savings ) || floatval( $optimization_savings ) < 0 ) {
+							echo '<p>' . esc_html__( 'Cimo did not optimize this attachment.', 'cimo-image-optimizer' ) . '</p>';
+							return;
+						}
+
 						$kb_saved = cimo_format_filesize( $original_filesize - $converted_filesize, 1, true );
 						$optimization_savings_class = ( $optimization_savings > 0 ) ? 'cimo-optimization-savings-up' : 'cimo-optimization-savings-down';
 
@@ -132,6 +138,7 @@ function cimo_get_media_type_label( $mimetype ) {
 						$converted_format_raw = isset( $cimo['convertedFormat'] ) ? $cimo['convertedFormat'] : ( isset( $post->post_mime_type ) ? $post->post_mime_type : '' );
 						$converted_format = $converted_format_raw ? cimo_convert_mimetype_to_format( $converted_format_raw ) : '';
 						$media_type_label = cimo_get_media_type_label( $converted_format_raw );
+						$is_image_media = is_string( $converted_format_raw ) && strpos( strtolower( $converted_format_raw ), 'image/' ) === 0;
 						$converttime = isset( $cimo['conversionTime'] ) ? floatval( $cimo['conversionTime'] ) : null;
 						if ( $converttime !== null ) {
 							if ( $converttime < 1000 ) {
@@ -207,7 +214,9 @@ function cimo_get_media_type_label( $mimetype ) {
 							echo '<li class="cimo-bulk-optimization-number">';
 							echo '🏞️ ' . sprintf(
 								/* translators: %s: bulk optimization count */
-								esc_html__( '%s thumbnail(s) processed', 'cimo-image-optimizer' ),
+								$is_image_media
+									? esc_html__( '%s thumbnail(s) processed', 'cimo-image-optimizer' )
+									: esc_html__( '%s file(s) processed', 'cimo-image-optimizer' ),
 								'<span class="cimo-value">' . esc_html( $bulk_optimization_count ) . '</span>'
 							);
 							echo '</li>';

src/admin/js/media-manager/sidebar-info.js

@@ -118,6 +118,7 @@ function injectCimoMetadata( {
 
 	const convertedFormatRaw = customMetadata.convertedFormat || model.get( 'mime' ) || ''
 	const mediaTypeLabel = getMediaTypeLabel( convertedFormatRaw )
+	const isImageMedia = typeof convertedFormatRaw === 'string' && convertedFormatRaw.startsWith( 'image/' )
 
 	let html = `
 		<div class="cimo-media-manager-metadata-title-container">
@@ -135,6 +136,15 @@ function injectCimoMetadata( {
 		? ( 100 - ( customMetadata.compressionSavings * 100 ) ).toFixed( 2 )
 		: ( 100 * ( originalFilesize - convertedFilesize ) / originalFilesize ).toFixed( 2 )
 
+	// If optimizationSavings is not a valid number or is negative, do not display it
+	if (
+		optimizationSavings === 'NaN' ||
+		! Number.isFinite( Number( optimizationSavings ) ) ||
+		Number( optimizationSavings ) < 0
+	) {
+		return
+	}
+
 	const kbSaved = formatFilesize(
 		originalFilesize - convertedFilesize,
 		1,
@@ -185,7 +195,7 @@ function injectCimoMetadata( {
 	if ( isBulkOptimized ) {
 		html += `
 			<li class="cimo-bulk-optimization-number">
-				🏞️ <span class="cimo-value">${ escape( Object.keys( customMetadata.bulk_optimization ).length.toString() ) }</span> thumbnail(s) processed
+				🏞️ <span class="cimo-value">${ escape( Object.keys( customMetadata.bulk_optimization ).length.toString() ) }</span> ${ escape( isImageMedia ? 'thumbnail(s) processed' : 'file(s) processed' ) }
 			</li>
 			<li class="cimo-bulk-optimization-number">
 				⚡️ Bulk optimized

src/admin/js/page/admin-settings.js

@@ -707,7 +707,7 @@ const AdminSettings = () => {
 								<span aria-hidden="true">
 									<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" strokeWidth="2" strokeLinecap="round" strokeLinejoin="round" className="lucide lucide-images-icon lucide-images"><path d="m22 11-1.296-1.296a2.4 2.4 0 0 0-3.408 0L11 16" /><path d="M4 8a2 2 0 0 0-2 2v10a2 2 0 0 0 2 2h10a2 2 0 0 0 2-2" /><circle cx="13" cy="7" r="1" fill="currentColor" /><rect x="8" y="2" width="14" height="14" rx="2" /></svg>
 								</span>
-								{ __( 'Bulk Image Optimization', 'cimo-image-optimizer' ) }
+								{ __( 'Bulk Optimization', 'cimo-image-optimizer' ) }
 							</h2>
 							{ buildType === 'free' && (
 								<span

src/shared/converters/image-converter.js

@@ -318,7 +318,7 @@ class ImageConverter extends Converter {
 				return {
 					file,
 					metadata: null,
-					reason: 'resulting-image-bigger-than-input',
+					reason: 'resulting-media-bigger-than-input',
 					error: `Resulting image is bigger than the input (input: ${ file.size } bytes, output: ${ convertedBlob.size } bytes), skipping conversion.`,
 				}
 			}